From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932586AbcEXNcD (ORCPT ); Tue, 24 May 2016 09:32:03 -0400 Received: from galahad.ideasonboard.com ([185.26.127.97]:59929 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932550AbcEXNcA (ORCPT ); Tue, 24 May 2016 09:32:00 -0400 From: Laurent Pinchart To: Kuninori Morimoto Cc: David Airlie , dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, koji.matsuoka.xm@renesas.com, yoshihiro.shimoda.uh@renesas.com, naoya.shiiba.nx@renesas.com, ryo.kodama.vz@renesas.com, hiroyuki.yokoyama.vx@renesas.com, yoshifumi.hosoya.wj@renesas.com, takeshi.kihara.df@renesas.com, toshiaki.komatsu.ud@renesas.com, harunobu.kurokawa.dn@renesas.com, ryusuke.sakato.bx@renesas.com, tomoharu.fukawa.eb@renesas.com, kouei.abe.cp@renesas.com, khiem.nguyen.xt@rvc.renesas.com, hien.dang.eb@rvc.renesas.com Subject: Re: [PATCH] drm: rcar-du: EPROBE_DEFER case doesn't need error message Date: Tue, 24 May 2016 16:32:13 +0300 Message-ID: <3209827.hXSB4Y22Yy@avalon> User-Agent: KMail/4.14.10 (Linux/4.4.6-gentoo; KDE/4.14.16; x86_64; ; ) In-Reply-To: <87posc9gg6.wl%kuninori.morimoto.gx@renesas.com> References: <87posc9gg6.wl%kuninori.morimoto.gx@renesas.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Morimoto-san, Thank you for the patch. On Tuesday 24 May 2016 14:24:09 Kuninori Morimoto wrote: > From: Kuninori Morimoto > > EPROBE_DEFER is not error, thus, error message on kernel log on this > case is confusable for user. Prints it only error cases. > > Signed-off-by: Kuninori Morimoto > --- > drivers/gpu/drm/rcar-du/rcar_du_drv.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c > b/drivers/gpu/drm/rcar-du/rcar_du_drv.c index 26fd3ba..1db080c 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c > +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c > @@ -354,14 +354,16 @@ static int rcar_du_probe(struct platform_device *pdev) > */ > ret = drm_vblank_init(ddev, (1 << rcdu->info->num_crtcs) - 1); > if (ret < 0) { > - dev_err(&pdev->dev, "failed to initialize vblank\n"); > + if (ret != -EPROBE_DEFER) I don't think this can ever happen. Actually, the only reason drm_vblank_init() could return an error at the moment is a kcalloc() failure, so we could remove this message completely. > + dev_err(&pdev->dev, "failed to initialize vblank\n"); > goto error; > } > > /* DRM/KMS objects */ > ret = rcar_du_modeset_init(rcdu); > if (ret < 0) { > - dev_err(&pdev->dev, "failed to initialize DRM/KMS (%d)\n", ret); > + if (ret != -EPROBE_DEFER) > + dev_err(&pdev->dev, "failed to initialize DRM/KMS (%d)\n", ret); > goto error; > } -- Regards, Laurent Pinchart