From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757945AbcBXQ5t (ORCPT ); Wed, 24 Feb 2016 11:57:49 -0500 Received: from mout.kundenserver.de ([212.227.126.133]:60349 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757662AbcBXQ5q (ORCPT ); Wed, 24 Feb 2016 11:57:46 -0500 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: Eddie Huang , Alessandro Zummo , rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org, Javier Martinez Canillas , linux-mediatek@lists.infradead.org, Alexandre Belloni Subject: Re: [PATCH] rtc: mt6397: Add platform device ID table Date: Wed, 24 Feb 2016 17:56:57 +0100 Message-ID: <3216713.qF8RyQVuPO@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1455628747.2981.4.camel@mtksdaap41> References: <1455016095-13724-1-git-send-email-javier@osg.samsung.com> <2416670.q30ahHlzPm@wuerfel> <1455628747.2981.4.camel@mtksdaap41> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:tCjrDd0Nb9faJdFANEtNn5uW8joTVRb3Ockl608KhS7lgjBKEYq GbU1jWggR8TQSSaj8XnxvrO+MNXUMIR7rIFIFE4IFHGEvnTaNnfqwPFb6Xr4sNrKAaHvn+e 7GjcrFWB0YisoVect8JIwNAsSEY316YEXZA0dWom9IO278uzCRbyFzRDjOvGuW5a5LNVKQu RBNtYbTK3V7ekA1Johukw== X-UI-Out-Filterresults: notjunk:1;V01:K0:hw3opGB4AWg=:zDVORvr4EognkFgw/EpHd9 zdDI+eJBRv9pn112VQO0tUp+2MNRHXggSM+B9bxbltwsgdPJLZQhlNJacpC+FCn8BdWhJvZeD MBDNoi+N6+BpDCCW7I6/JY+zmXGAWi62eCiJYlOQi+4gvZgGq2Hlg0hYz8aIpfzEno285+nZU jxr5E/jMEQZqeNNECdkdXotrj0oWonjRVuOLjqafw+e4sSKh4vtlCTHYPZoOsQEGfDlHhReO6 f+U6gC7K4mG7yakKOWAiq20R27OFUPugmRdJdW0ef5SCuDBf6mj+eXa5gMCxohnv09BylAeGG CfLqBbHY8SHcTFvC0EoFb0kyqMWex5oGMR0tKv+AlCyBCYt68vtPKz+3FJuFPeWulHpZYlPRO 5AtcP9M4PzsbjDg+rmQQV8Ay+hbsYt4Q+NoSV0ECxutNc9sIlgtNOVe3VfoFKmkXtsAmfVI2B pz7fJOxiCraTpPhAYRPRGg/2gTzsmcQ9k5iaCNhcIye4mYmXnb+qr4nGLHh4z8QBvWl7FLmXP DCoH6ce6mFspSDdBSmwKdf6XJhgZBOyGzjHmdcrQr0pPwyoqY8SGTJf06EMuym2k5wri0L+Us JNT00jc8mYtQH0BbC+2SSCtQv2I0Q02JRHvO1gECn8K2F38FJZxoGQTU4tzWhh9xy5HtZZbdj fD0G7UyYpepxbDNgFbb01FGmScsrc99GjdFiYfMu1upj5eyXyZhZpfvQPmUzf7EWE28Gv0d7g BTRfeeZeDnnydmJ4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 16 February 2016 21:19:07 Eddie Huang wrote: > On Tue, 2016-02-16 at 12:37 +0100, Arnd Bergmann wrote: > > On Monday 15 February 2016 11:50:48 Javier Martinez Canillas wrote: > > > > > > On 02/14/2016 10:58 PM, Eddie Huang wrote: > > > > > > [snip] > > > > > > >> @@ -412,6 +418,7 @@ static struct platform_driver mtk_rtc_driver = { > > > >> }, > > > >> .probe = mtk_rtc_probe, > > > >> .remove = mtk_rtc_remove, > > > >> + .id_table = mt6397_rtc_id, > > > >> }; > > > >> > > > >> module_platform_driver(mtk_rtc_driver); > > > >> @@ -419,4 +426,3 @@ module_platform_driver(mtk_rtc_driver); > > > >> MODULE_LICENSE("GPL v2"); > > > >> MODULE_AUTHOR("Tianping Fang "); > > > >> MODULE_DESCRIPTION("RTC Driver for MediaTek MT6397 PMIC"); > > > >> -MODULE_ALIAS("platform:mt6397-rtc"); > > > > > > > > This patch looks good to me, but I am wondering, since we tend to use > > > > device tree method to match driver, do we still need support platform > > > > device ID ? > > > > > > > > > > I'm not familiar with neither this IP block nor the SoC so it is up to > > > you. I just noticed this issue when reviewing a regulator driver for a > > > similar PMIC posted by someone from mediatek. > > > > > > I thought platform device was needed since the driver has a MODULE_ALIAS() > > > but please let me know what you prefer and I can re-spin the patch and > > > just remove the MODULE_ALIAS() if that makes more sense for this platform. > > > > > > > > > > I agree. We can alway add a MODULE_DEVICE_TABLE() if we get multiple > > users of this driver on architectures that don't use devicetree yet. > > > > Sure. Thanks the patch to add expandability to this driver. > > Acked-by: Eddie Huang I think we misunderstood one another. I think we can drop both the MODULE_DEVICE_TABLE and the MODULE_ALIAS: there is no need for another driver ID when it is always probed using DT. Arnd