From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756028AbbI2Hh0 (ORCPT <rfc822;w@1wt.eu>);
	Tue, 29 Sep 2015 03:37:26 -0400
Received: from mout.kundenserver.de ([212.227.17.24]:50449 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1755934AbbI2HhR (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 29 Sep 2015 03:37:17 -0400
From: Arnd Bergmann <arnd@arndb.de>
To: Ley Foon Tan <lftan@altera.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Linux-Arch <linux-arch@vger.kernel.org>, linux-pci@vger.kernel.org
Subject: Re: [PATCH 1/2] nios2: Add architectural support for PCIe
Date: Tue, 29 Sep 2015 09:37:09 +0200
Message-ID: <3218771.zBxT0jYLDs@wuerfel>
User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
In-Reply-To: <CAFiDJ5_jkEqdAY=TtKOg6=GzT8i4qAFdnSH_z1RsoPVU2Vfr1Q@mail.gmail.com>
References: <1442906367-10935-1-git-send-email-lftan@altera.com> <5408024.XroFc5QNep@wuerfel> <CAFiDJ5_jkEqdAY=TtKOg6=GzT8i4qAFdnSH_z1RsoPVU2Vfr1Q@mail.gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:AMDw9AQhZZpOnyg5LhxkCceQOnLr4I1hoI+xkJKqwHopjuvjWU/
 GwcQspAeJHWcMu9rEyiaO7VjnWxAi2/SQk8HTY4An66VMOPOu2Y5Xh5jZhUYVU+6xHYwtfz
 brbIatxBSi/dciXUB2kuQgIVHp6+CRT+6gezUL6PSxR+OjhfnaT9esSKnlsOq2CYemkkD12
 ibKUv0/UqSU1JR7LAeSPA==
X-UI-Out-Filterresults: notjunk:1;V01:K0:3ahQfPf+7Os=:L5oQWrIca4+FV9N9okR//6
 9vQJQ7OrM1+AwZ3OUHFCHKLK+DJph/Odwryp08wriO/T70FYUyTSf5KOu0BMopC/eVYDhr3I9
 /1/iHhkaW+fV25S9Y1hfwy8LckUQQlBPNpDFZ3V32ZUNCGashpjgTtSlqOb42p4SpotnjBtsJ
 v20jGruwszZAMb53fCnkWGWCxZJl0wnHrQx6Bjj0+93jb98ZIy9gHX/7/WOvfHCpXuVqXZyFT
 AQqBaQSxZyc7m8/QRVFhLNljPaptMVcx7LH2+/BAYh2UVa+GWthyHCpw/MounvTdvWTrh5Wim
 kY84Y2Y7757SNyjQo0NtdRMCZyWisUo65L+KDukR96f1ii0t8K7sDntC20rAFOwvbSoo2ecM2
 eUOSnYyTSntT7gdxmasWIGomOZd8zL1DTsxpQd46b+9tBXa4qYnnhS8SDjTPcR9hjMH1Wa8AD
 kjDqEDeMbLTP66LeWOltp7T+FaO5VPb1wLx0tMln1v1zmkIPgeKbEDnwLrKWCoban0RbGFu2k
 QrhmpFwIdhdu+q+Ks6aMJTCrTIocpmpLHtTVPJCocgJaSshT1IipGGuGBmLpTKtiMsDTFoJbT
 WxshFZJ0zfGhDmlZE0i/vptQuVAUi819Uh3xzqAHwZg6UcHhLmdAKBLsV4alR8o7b3bGR1t8N
 D0Dz998gboDVXSCYiomRztSYwq597XNK8BDIGvvCLWswZR81JrcBbXEqzzyCaBfkqKWNsrffG
 H3UXU5FqPL7oe4mX
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tuesday 29 September 2015 11:12:24 Ley Foon Tan wrote:
> >
> > I think that would be good, yes. We probably picked defaults for the
> > asm-generic version that are enough to build with CONFIG_PCI disabled,
> > but there are useful defaults for the other case as well.
> >
> > Most architectures that use the file don't support PCI, so you can just
> > add stuff inside of #ifdef CONFIG_PCI. For the remaining 13 architectures
> > (git grep -l generic/pci.h  | wc), see whether there are conflicts first.
> > The normal way would be to have the arch specific definition come before
> > the #include, and then do something like
> >
> > #ifndef pci_proc_domain
> > #define pci_proc_domain pci_proc_domain
> > static inline int pci_proc_domain(struct pci_bus *bus)
> > {
> > #ifdef CONFIG_PCI_DOMAINS_GENERIC
> >         return pci_domain_nr(bus);
> > #else
> >         return 1;
> > }
> > #endif
> 
> Okay, will try add them to asm-generic.

Thanks

> Do you prefer to send it as separate patch or can be part of this patchset?

I prefer the patches to be part of this series and merged through together
with them.

	Arnd