From: David Howells <dhowells@redhat.com>
To: unlisted-recipients:; (no To-header on input)
Cc: dhowells@redhat.com, dwmw2@infradead.org,
David Woodhouse <David.Woodhouse@intel.com>,
linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org, keyrings@vger.kernel.org,
Mimi Zohar <zohar@linux.vnet.ibm.com>
Subject: Re: [RFC PATCH] X.509: Don't check the signature on apparently self-signed keys [ver #2]
Date: Tue, 05 Jan 2016 15:55:40 +0000 [thread overview]
Message-ID: <32191.1452009340@warthog.procyon.org.uk> (raw)
In-Reply-To: <20160105154703.31650.95150.stgit@warthog.procyon.org.uk>
David Howells <dhowells@redhat.com> wrote:
> If a certificate is self-signed, don't bother checking the validity of the
> signature. The cert cannot be checked by validation against the next one
> in the chain as this is the root of the chain. Trust for this certificate
> can only be determined by whether we obtained it from a trusted location
> (ie. it was built into the kernel at compile time).
>
> This also fixes a bug whereby certificates were being assumed to be
> self-signed if they had neither AKID nor SKID, the symptoms of which show
> up as an attempt to load a certificate failing with -ERANGE or -EBADMSG.
> This is produced from the RSA module when the result of calculating "m =
> s^e mod n" is checked.
Oops - I forgot to change the patch description.
David
next prev parent reply other threads:[~2016-01-05 15:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-05 15:47 [RFC PATCH] X.509: Don't check the signature on apparently self-signed keys [ver #2] David Howells
2016-01-05 15:55 ` David Howells [this message]
2016-01-05 16:08 ` Mimi Zohar
2016-01-05 16:39 ` David Howells
2016-01-06 12:22 ` Mimi Zohar
2016-01-06 13:21 ` David Howells
2016-01-06 14:03 ` Mimi Zohar
2016-01-06 14:19 ` David Howells
2016-01-06 17:00 ` Petko Manolov
2016-01-05 16:40 ` David Howells
2016-01-05 17:00 ` Petko Manolov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32191.1452009340@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=David.Woodhouse@intel.com \
--cc=dwmw2@infradead.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox