Re: [PATCH v2 4/6] KVM: x86: refactor pic setup in kvm_set_routing_entry

[David Hildenbrand <david@redhat.com>]

Am 16.12.2016 um 16:10 schrieb Radim Krčmář:
> Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: Radim Krčmář <rkrcmar@redhat.com>
> ---
>  v2: r-b Paolo
> ---
>  arch/x86/kvm/irq_comm.c | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/arch/x86/kvm/irq_comm.c b/arch/x86/kvm/irq_comm.c
> index 6c0191615f23..1dfeb185a1e3 100644
> --- a/arch/x86/kvm/irq_comm.c
> +++ b/arch/x86/kvm/irq_comm.c
> @@ -297,15 +297,13 @@ int kvm_set_routing_entry(struct kvm *kvm,
>  	case KVM_IRQ_ROUTING_IRQCHIP:
>  		delta = 0;
>  		switch (ue->u.irqchip.irqchip) {
> +		case KVM_IRQCHIP_PIC_SLAVE:
> +			delta = 8;
> +			/* fall through */
>  		case KVM_IRQCHIP_PIC_MASTER:
>  			e->set = kvm_set_pic_irq;
>  			max_pin = PIC_NUM_PINS;
>  			break;
> -		case KVM_IRQCHIP_PIC_SLAVE:
> -			e->set = kvm_set_pic_irq;
> -			max_pin = PIC_NUM_PINS;
> -			delta = 8;
> -			break;
>  		case KVM_IRQCHIP_IOAPIC:
>  			max_pin = KVM_IOAPIC_NUM_PINS;
>  			e->set = kvm_set_ioapic_irq;
>

Had the exact same thing in mind when reading that piece of code.

Reviewed-by: David Hildenbrand <david@redhat.com>

-- 

David