From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751876AbaKYJbc (ORCPT ); Tue, 25 Nov 2014 04:31:32 -0500 Received: from gloria.sntech.de ([95.129.55.99]:33369 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750901AbaKYJb2 (ORCPT ); Tue, 25 Nov 2014 04:31:28 -0500 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Alexandru M Stan , Mike Turquette Cc: Doug Anderson , addy ke , Sonny Rao , Kever Yang , linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, mark.rutland@arm.com, pawel.moll@arm.com, ijc+devicetree@hellion.org.uk, linux-kernel@vger.kernel.org, robh+dt@kernel.org, galak@codeaurora.org, mark.yao@rock-chips.com Subject: Re: [PATCH v3 0/2] Add support for the rockchip mmc clock phases using the framework Date: Tue, 25 Nov 2014 10:35:06 +0100 Message-ID: <3222595.cbGxNcWa4c@diego> User-Agent: KMail/4.14.1 (Linux/3.16-3-amd64; KDE/4.14.2; x86_64; ; ) In-Reply-To: <1416344908-5975-1-git-send-email-amstan@chromium.org> References: <1416344908-5975-1-git-send-email-amstan@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Dienstag, 18. November 2014, 13:08:26 schrieb Alexandru M Stan: > For now all I have is the getter and setter for the phase, nothing that uses > it (that is ready). You can test the getter like this: > localhost ~ # cat /sys/kernel/debug/clk/clk_summary|grep sample -C 1 > sclk_sdio1 0 0 24000000 > 0 0 sdio1_sample 0 0 12000000 > 0 0 sdio1_drv 0 0 12000000 > 0 90 -- > sclk_sdmmc 1 1 297000000 > 0 0 sdmmc_sample 0 0 148500000 0 134 > sdmmc_drv 0 0 148500000 0 90 -- > sclk_sdio0 1 1 100000000 > 0 0 sdio0_sample 0 0 50000000 0 0 > sdio0_drv 0 0 50000000 0 90 > sclk_emmc 1 1 100000000 0 0 > emmc_sample 0 0 50000000 0 0 > emmc_drv 0 0 50000000 0 180 > > Next thing that will come is some dts changes that will make use of these > new clocks, and eventually mmc code will be changed to tune with these > clocks. As already said in v1, this looks nice to me, but I'll give Mike another day or two to voice possible concerns. Heiko