Re: [PATCH v3 net-next 03/12] net: dsa: inherit the actual bridge port flags at join time

kernel test robot
2021-03-21T00:15:09Z

[-- Attachment #1: Type: text/plain, Size: 3503 bytes --]

Hi Vladimir,

I love your patch! Perhaps something to improve:

[auto build test WARNING on net-next/master]

url: https://github.com/0day-ci/linux/commits/Vladimir-Oltean/Better-support-for-sandwiched-LAGs-with-bridge-and-DSA/20210321-063842
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git d773b7957e4fd7b732a163df0e59d31ad4237302
config: arm-mvebu_v5_defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/3aac17167e3de0aeaf5287f9d586725bdc7495a5
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Vladimir-Oltean/Better-support-for-sandwiched-LAGs-with-bridge-and-DSA/20210321-063842
git checkout 3aac17167e3de0aeaf5287f9d586725bdc7495a5
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

In file included from include/linux/device.h:15,
from include/linux/dma-mapping.h:7,
from include/linux/skbuff.h:31,
from include/net/net_namespace.h:39,
from include/linux/netdevice.h:37,
from include/linux/if_bridge.h:12,
from net/dsa/port.c:9:
net/dsa/port.c: In function 'dsa_port_clear_brport_flags':
>> net/dsa/port.c:166:5: warning: format '%d' expects argument of type 'int', but argument 3 has type 'long unsigned int' [-Wformat=]
166 | "failed to clear bridge port flag %d: %d (%pe)\n",
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:19:22: note: in definition of macro 'dev_fmt'
19 | #define dev_fmt(fmt) fmt
| ^~~
net/dsa/port.c:165:4: note: in expansion of macro 'dev_err'
165 | dev_err(dp->ds->dev,
| ^~~~~~~
net/dsa/port.c:166:40: note: format string is defined here
166 | "failed to clear bridge port flag %d: %d (%pe)\n",
| ~^
| |
| int
| %ld

vim +166 net/dsa/port.c

148
149 static void dsa_port_clear_brport_flags(struct dsa_port *dp,
150 struct netlink_ext_ack *extack)
151 {
152 const unsigned long val = BR_FLOOD | BR_MCAST_FLOOD | BR_BCAST_FLOOD;
153 const unsigned long mask = BR_LEARNING | BR_FLOOD | BR_MCAST_FLOOD |
154 BR_BCAST_FLOOD;
155 int flag, err;
156
157 for_each_set_bit(flag, &mask, 32) {
158 struct switchdev_brport_flags flags = {0};
159
160 flags.mask = BIT(flag);
161 flags.val = val & BIT(flag);
162
163 err = dsa_port_bridge_flags(dp, flags, extack);
164 if (err && err != -EOPNOTSUPP)
165 dev_err(dp->ds->dev,
> 166 "failed to clear bridge port flag %d: %d (%pe)\n",
167 flags.val, err, ERR_PTR(err));
168 }
169 }
170

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 26446 bytes --]