public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: Joel Becker <Joel.Becker@oracle.com>
Cc: dhowells@redhat.com, Ulrich Drepper <drepper@gmail.com>,
	viro@zeniv.linux.org.uk, smfrench@gmail.com, jlayton@redhat.com,
	mcao@us.ibm.com, aneesh.kumar@linux.vnet.ibm.com,
	linux-cifs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-kernel@vger.kernel.org, samba-technical@lists.samba.org,
	sjayaraman@suse.de, linux-ext4@vger.kernel.org
Subject: Re: [PATCH 3/3] Add a pair of system calls to make extended file stats available
Date: Wed, 30 Jun 2010 00:29:52 +0100	[thread overview]
Message-ID: <32322.1277854192@redhat.com> (raw)
In-Reply-To: <20100629224844.GF4150@mail.oracle.com>

Joel Becker <Joel.Becker@oracle.com> wrote:

> 	The less variable length stuff the better, I think.  At least,
> for the stuff stat(2) already returns, you should have a fixed-size
> structure.  Even if I only pass the GIVE_ME_UIDS flag, I don't want to
> have to deal with the variable size stuff until I've actually asked for
> esoteric things.  I'll know that the non-UIDS fields are garbage by the
> fact that I didn't ask for them.

I was thinking of the fixed length xstat struct plus appendable extensions to
be defined later.

I could live with each defined extension being of a fixed length, so for
example, you set bit 20, and it adds, say, a 16-byte volume ID in the
appropriate order, padded out appropriately for the filesystem.

David

  reply	other threads:[~2010-06-29 23:30 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-29 20:02 [PATCH 0/3] Extended file stat functions David Howells
2010-06-29 20:03 ` [PATCH 1/3] Mark arguments to certain syscalls as being const David Howells
2010-06-29 20:03 ` [PATCH 2/3] AFS: Use i_generation not i_version for the vnode uniquifier David Howells
2010-06-29 20:03 ` [PATCH 3/3] Add a pair of system calls to make extended file stats available David Howells
2010-06-29 22:13   ` Ulrich Drepper
2010-06-29 22:33     ` Steve French
2010-06-29 22:36     ` David Howells
2010-06-29 22:48       ` Joel Becker
2010-06-29 23:29         ` David Howells [this message]
2010-07-01  1:12           ` Joel Becker
2010-06-29 22:48       ` Sage Weil
2010-06-30  8:20   ` Arnd Bergmann
2010-06-30  8:59     ` David Howells
2010-06-29 20:23 ` [PATCH 0/3] Extended file stat functions Steve French
2010-06-29 20:41   ` David Howells
2010-06-29 20:28 ` Trond Myklebust
2010-06-29 20:50   ` David Howells
2010-06-29 21:07 ` Bernd Schubert
2010-06-29 21:11   ` David Howells
2010-06-29 21:24     ` Bernd Schubert
2010-06-29 21:28       ` David Howells
2010-06-29 21:53         ` Bernd Schubert
2010-06-29 22:59         ` Maciej W. Rozycki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=32322.1277854192@redhat.com \
    --to=dhowells@redhat.com \
    --cc=Joel.Becker@oracle.com \
    --cc=aneesh.kumar@linux.vnet.ibm.com \
    --cc=drepper@gmail.com \
    --cc=jlayton@redhat.com \
    --cc=linux-cifs@vger.kernel.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mcao@us.ibm.com \
    --cc=samba-technical@lists.samba.org \
    --cc=sjayaraman@suse.de \
    --cc=smfrench@gmail.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox