public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Linux PM <linux-pm@vger.kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Linux ACPI <linux-acpi@vger.kernel.org>,
	Zhang Rui <rui.zhang@intel.com>,
	Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
	Daniel Lezcano <daniel.lezcano@linaro.org>
Subject: [PATCH v1 4/6] thermal: intel: int340x: Rearrange int340x_thermal_read_trips()
Date: Tue, 24 Jan 2023 20:17:09 +0100	[thread overview]
Message-ID: <3238718.44csPzL39Z@kreacher> (raw)
In-Reply-To: <12159228.O9o76ZdvQC@kreacher>

From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

Use local variables trips and adev to store the addresses of the given
thermal zone's trip point table and ACPI device, respectively, and use
them to shorten some code lines.

No intentional functional impact.

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---
 drivers/thermal/intel/int340x_thermal/int340x_thermal_zone.c |   10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

Index: linux-pm/drivers/thermal/intel/int340x_thermal/int340x_thermal_zone.c
===================================================================
--- linux-pm.orig/drivers/thermal/intel/int340x_thermal/int340x_thermal_zone.c
+++ linux-pm/drivers/thermal/intel/int340x_thermal/int340x_thermal_zone.c
@@ -66,25 +66,27 @@ static struct thermal_zone_device_ops in
 
 int int340x_thermal_read_trips(struct int34x_thermal_zone *int34x_zone)
 {
+	struct thermal_trip *trips = int34x_zone->trips;
+	struct acpi_device *adev = int34x_zone->adev;
 	int trip_cnt;
 	int i, ret;
 
 	trip_cnt = int34x_zone->aux_trip_nr;
 
-	ret = thermal_acpi_trip_critical(int34x_zone->adev, &int34x_zone->trips[trip_cnt]);
+	ret = thermal_acpi_trip_critical(adev, &trips[trip_cnt]);
 	if (!ret)
 		trip_cnt++;
 
-	ret = thermal_acpi_trip_hot(int34x_zone->adev, &int34x_zone->trips[trip_cnt]);
+	ret = thermal_acpi_trip_hot(adev, &trips[trip_cnt]);
 	if (!ret)
 		trip_cnt++;
 
-	ret = thermal_acpi_trip_passive(int34x_zone->adev, &int34x_zone->trips[trip_cnt]);
+	ret = thermal_acpi_trip_passive(adev, &trips[trip_cnt]);
 	if (!ret)
 		trip_cnt++;
 
 	for (i = 0; i < INT340X_THERMAL_MAX_ACT_TRIP_COUNT; i++) {
-		ret = thermal_acpi_trip_active(int34x_zone->adev, i, &int34x_zone->trips[trip_cnt]);
+		ret = thermal_acpi_trip_active(adev, i, &trips[trip_cnt]);
 		if (ret)
 			break;
 




  parent reply	other threads:[~2023-01-24 19:19 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-24 19:07 [PATCH v1 0/6] thermal: intel: int340x: Assorted cleanup changes Rafael J. Wysocki
2023-01-24 19:13 ` [PATCH v1 1/6] thermal: intel: int340x: Assorted minor cleanups Rafael J. Wysocki
2023-01-24 19:14 ` [PATCH v1 2/6] thermal: intel: int340x: Rename variable in int340x_thermal_zone_add() Rafael J. Wysocki
2023-01-24 19:16 ` [PATCH v1 3/6] thermal: intel: int340x: Evaluate GTSH once Rafael J. Wysocki
2023-01-24 19:17 ` Rafael J. Wysocki [this message]
2023-01-24 19:18 ` [PATCH v1 5/6] thermal: intel: int340x: Populate auxiliary trip points first Rafael J. Wysocki
2023-01-24 19:18 ` [PATCH v1 6/6] thermal: intel: int340x: Drop pointless cast to unsigned long Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3238718.44csPzL39Z@kreacher \
    --to=rjw@rjwysocki.net \
    --cc=daniel.lezcano@linaro.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rui.zhang@intel.com \
    --cc=srinivas.pandruvada@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox