From: David Woodhouse <dwmw2@infradead.org>
To: Dawson Engler <engler@csl.Stanford.EDU>
Cc: linux-kernel@vger.kernel.org, mc@cs.Stanford.EDU
Subject: Re: [CHECKER] 56 potential lock/unlock bugs in 2.5.8
Date: Fri, 12 Jul 2002 14:17:29 +0100 [thread overview]
Message-ID: <32493.1026479849@redhat.com> (raw)
In-Reply-To: <200207112135.OAA03801@csl.Stanford.EDU>
engler@csl.Stanford.EDU said:
> /u2/engler/mc/oses/linux/2.5.8/drivers/mtd/chips/cfi_cmdset_0001.c:782:
> do_write_buffer: ERROR:A_B:700:782:Did not reverse 'spin_lock'
> [COUNTER=spin_lock:700] [fit=3] [fit_fn=1] [fn_ex=5] [fn_counter=1]
> [ex=5619] [counter=272] [z = 1.34804760770983] [fn-z =
> -1.31122013621437]
That one can't ever actually happen -- it's effectively a default case in a
switch statement which can't ever be reached because we'd never get that far
unless one of the real cases is going to be taken. I think I'll replace the
return statement with panic("The world is broken");
--
dwmw2
next prev parent reply other threads:[~2002-07-12 13:15 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-07-11 21:35 [CHECKER] 56 potential lock/unlock bugs in 2.5.8 Dawson Engler
2002-07-11 21:54 ` Thunder from the hill
2002-07-11 22:21 ` Oliver Neukum
2002-07-11 23:14 ` Thunder from the hill
2002-07-11 23:32 ` Andreas Dilger
2002-07-11 23:45 ` Thunder from the hill
2002-07-11 23:41 ` Chris Wright
2002-07-12 0:21 ` Andrew Morton
2002-07-12 1:44 ` Arnaldo Carvalho de Melo
2002-07-12 17:40 ` Roman Zippel
2002-07-12 17:53 ` Thunder from the hill
2002-07-12 18:37 ` Roman Zippel
2002-07-12 18:05 ` Dave Jones
2002-07-12 18:32 ` Roman Zippel
2002-07-12 18:37 ` Dave Jones
2002-07-12 20:34 ` Roman Zippel
2002-07-12 20:48 ` Dave Jones
2002-07-12 21:30 ` Roman Zippel
2002-07-12 21:38 ` Dave Jones
2002-07-12 21:56 ` Roman Zippel
2002-07-12 22:14 ` Dave Jones
2002-07-12 22:34 ` Roman Zippel
2002-07-12 22:41 ` Dave Jones
2002-07-12 13:17 ` David Woodhouse [this message]
2002-07-12 13:26 ` Thunder from the hill
-- strict thread matches above, loose matches on Subject: below --
2002-07-11 22:32 Grover, Andrew
2002-07-11 23:26 ` Dawson Engler
[not found] <200207112135.OAA03801@csl.Stanford.EDU.suse.lists.linux.kernel>
2002-07-11 22:34 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32493.1026479849@redhat.com \
--to=dwmw2@infradead.org \
--cc=engler@csl.Stanford.EDU \
--cc=linux-kernel@vger.kernel.org \
--cc=mc@cs.Stanford.EDU \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox