Re: [PATCH v3 net-next 06/10] dt-bindings: net: dsa: mediatek,mt7530: fix port description location

Arınç ÜNAL
2022-11-28T08:29:54Z

On 28.11.2022 01:47, Colin Foster wrote:
> The description property was located where it applies to every port, not
> just ports 5 or 6 (CPU ports). Fix this description.

I'm not sure I understand. The description for reg does apply to every
port. Both CPU ports and user ports are described. This patch moves the
description to under CPU ports only.

>
> Suggested-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Colin Foster <colin.foster@in-advantage.com>
> ---
>
> v2 -> v3
> * New patch.
>
> ---
> .../bindings/net/dsa/mediatek,mt7530.yaml | 14 +++-----------
> 1 file changed, 3 insertions(+), 11 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml
> index 7df4ea1901ce..415e6c40787e 100644
> --- a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml
> +++ b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml
> @@ -156,17 +156,6 @@ patternProperties:
>
> patternProperties:
> "^(ethernet-)?port@[0-9]+$":
> - type: object
> - description: Ethernet switch ports
> -
> - unevaluatedProperties: false
> -

Would be nice to mention these being removed on the patch log. Or remove
them while doing ("dt-bindings: net: dsa: utilize base definitions for
standard dsa switches").

> - properties:
> - reg:
> - description:
> - Port address described must be 5 or 6 for CPU port and from 0 to 5
> - for user ports.
> -
> allOf:
> - $ref: dsa-port.yaml#
> - if:
> @@ -174,6 +163,9 @@ patternProperties:
> then:
> properties:
> reg:
> + description:
> + Port address described must be 5 or 6 for CPU port and from
> + 0 to 5 for user ports
> enum:
> - 5
> - 6

Thank you for your efforts.

Arınç