Re: [PATCH v3 net-next 04/10] dt-bindings: net: dsa: allow additional ethernet-port properties

Rob Herring
2022-11-28T23:28:08Z

On Sun, Nov 27, 2022 at 02:47:28PM -0800, Colin Foster wrote:
> Explicitly allow additional properties for both the ethernet-port and
> ethernet-ports properties. This specifically will allow the qca8k.yaml
> binding to use shared properties.
>
> Signed-off-by: Colin Foster <colin.foster@in-advantage.com>
> ---
>
> v2 -> v3
> * No change
>
> v1 -> v2
> * New patch
>
> ---
> Documentation/devicetree/bindings/net/dsa/dsa.yaml | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/net/dsa/dsa.yaml b/Documentation/devicetree/bindings/net/dsa/dsa.yaml
> index bd1f0f7c14a8..87475c2ab092 100644
> --- a/Documentation/devicetree/bindings/net/dsa/dsa.yaml
> +++ b/Documentation/devicetree/bindings/net/dsa/dsa.yaml
> @@ -38,6 +38,8 @@ patternProperties:
> '#size-cells':
> const: 0
>
> + additionalProperties: true
> +

Where then do we restrict adding properties to ethernet-ports nodes?

> patternProperties:
> "^(ethernet-)?port@[0-9]+$":
> type: object
> @@ -45,7 +47,7 @@ patternProperties:
>
> $ref: dsa-port.yaml#
>
> - unevaluatedProperties: false
> + unevaluatedProperties: true

Same question for ethernet-port nodes.

>
> oneOf:
> - required:
> --
> 2.25.1
>
>