From: Andrew Donnellan <ajd@linux.ibm.com>
To: Shrikanth Hegde <sshegde@linux.ibm.com>
Cc: npiggin@gmail.com, christophe.leroy@csgroup.eu,
mpe@ellerman.id.au, peterz@infradead.org, fbarrat@linux.ibm.com,
mahesh@linux.ibm.com, oohall@gmail.com, hbathini@linux.ibm.com,
dhowells@redhat.com, haren@linux.ibm.com,
linux-kernel@vger.kernel.org, maddy@linux.ibm.com,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 5/6] powerpc: powenv: oxcl: use lock guard for mutex
Date: Wed, 19 Mar 2025 14:59:38 +1100 [thread overview]
Message-ID: <324b4b5c6f1f0a777a217fdc05c8d01d4e0302ea.camel@linux.ibm.com> (raw)
In-Reply-To: <d6999d74-45f6-413a-8881-90473b322dfa@linux.ibm.com>
On Fri, 2025-03-14 at 15:00 +0530, Shrikanth Hegde wrote:
>
> Hi. Andrew,
>
> After this change below dev_dbg will be called with mutex held still.
> Is
> that a concern? I don't see the mutex being used in that path.
>
> Since using scoped_guard cause more code churn here, I would prefer
> not
> use it.
I think this is fine.
--
Andrew Donnellan OzLabs, ADL Canberra
ajd@linux.ibm.com IBM Australia Limited
next prev parent reply other threads:[~2025-03-19 4:00 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-14 5:45 [PATCH 0/6] powerpc: use lock guards for mutex Set 1 Shrikanth Hegde
2025-03-14 5:45 ` [PATCH 1/6] powerpc: eeh: use lock guard for mutex Shrikanth Hegde
2025-03-14 5:45 ` [PATCH 2/6] powerpc: rtas: " Shrikanth Hegde
2025-03-14 5:45 ` [PATCH 3/6] powerpc: fadump: " Shrikanth Hegde
2025-03-14 8:22 ` Peter Zijlstra
2025-03-14 9:08 ` Shrikanth Hegde
2025-03-14 5:45 ` [PATCH 4/6] powerpc: book3s: vas: " Shrikanth Hegde
2025-03-14 8:25 ` Peter Zijlstra
2025-03-14 9:27 ` Shrikanth Hegde
2025-03-14 5:45 ` [PATCH 5/6] powerpc: powenv: oxcl: " Shrikanth Hegde
2025-03-14 6:06 ` Andrew Donnellan
2025-03-14 6:57 ` Shrikanth Hegde
2025-03-14 9:30 ` Shrikanth Hegde
2025-03-14 10:33 ` Shrikanth Hegde
2025-03-19 3:59 ` Andrew Donnellan [this message]
2025-03-14 5:45 ` [PATCH 6/6] powerpc: sysdev: " Shrikanth Hegde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=324b4b5c6f1f0a777a217fdc05c8d01d4e0302ea.camel@linux.ibm.com \
--to=ajd@linux.ibm.com \
--cc=christophe.leroy@csgroup.eu \
--cc=dhowells@redhat.com \
--cc=fbarrat@linux.ibm.com \
--cc=haren@linux.ibm.com \
--cc=hbathini@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.ibm.com \
--cc=mahesh@linux.ibm.com \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=oohall@gmail.com \
--cc=peterz@infradead.org \
--cc=sshegde@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox