From: Paul Parsons <lost.distance@yahoo.com>
To: Samuel Ortiz <sameo@linux.intel.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] mfd: Add ASIC3 LED support
Date: Mon, 2 May 2011 23:16:23 +0100 (BST) [thread overview]
Message-ID: <325376.71935.qm@web29015.mail.ird.yahoo.com> (raw)
In-Reply-To: <20110502153951.GH8222@sortiz-mobl>
Hi Samuel,
--- On Mon, 2/5/11, Samuel Ortiz <sameo@linux.intel.com> wrote:
> Where is the LED driver ?
It was posted separately - [PATCH 2/2] leds: Add ASIC3 LED support - since drivers/mfd and drivers/leds are maintained separately. Sorry, I should have cross copied them.
> > -static int asic3_clk_enable(struct asic3 *asic,
> struct asic3_clk *clk)
> > +static void asic3_clk_enable(struct asic3 *asic,
> struct asic3_clk *clk)
> Although a valid change, this is unrelated to this patch.
Not completely unrelated; I call asic3_clk_enable() and found it simpler to remove the unnecessary return value rather than check it.
> > + asic->gpio.label = "asic3";
> Ditto.
Agreed; that was left in by mistake.
Should I resubmit?
Regards,
Paul
next prev parent reply other threads:[~2011-05-02 22:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-30 17:59 [PATCH 1/2] mfd: Add ASIC3 LED support Paul Parsons
2011-05-02 15:39 ` Samuel Ortiz
2011-05-02 22:16 ` Paul Parsons [this message]
2011-05-03 8:33 ` Samuel Ortiz
2011-05-03 10:41 ` Philipp Zabel
2011-05-03 10:46 ` Philipp Zabel
2011-05-03 15:38 ` Paul Parsons
2011-05-03 19:46 ` Paul Parsons
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=325376.71935.qm@web29015.mail.ird.yahoo.com \
--to=lost.distance@yahoo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox