From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1428611AbcBSUz1 (ORCPT ); Fri, 19 Feb 2016 15:55:27 -0500 Received: from mout.kundenserver.de ([217.72.192.74]:57163 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1423122AbcBSUz0 (ORCPT ); Fri, 19 Feb 2016 15:55:26 -0500 From: Arnd Bergmann To: Murali Karicheri Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, davem@davemloft.net Subject: Re: [PATCH v2 3/3] net: netcp: rework the code for get/set sw_data in dma desc Date: Fri, 19 Feb 2016 21:55:14 +0100 Message-ID: <3256728.DYdlef6xAF@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1455904724-17952-4-git-send-email-m-karicheri2@ti.com> References: <1455904724-17952-1-git-send-email-m-karicheri2@ti.com> <1455904724-17952-4-git-send-email-m-karicheri2@ti.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:RwuHCg+nVLf3gqUPR98wlAHXNOOm7/INEikYnSDzD5aA4YwRRy/ Ffo5jzu/JC3595jBsA6+wZz+s91T6pv41dtnNd+Hkq5FhvVBfpVf23npgGA7136NyMUtpaF 0zM5EUbdMlHJ9zrnU5GoOaW3Iyq+ETAfoHkSOq7gRtoaTXzdi8Nm9bbDJ4oN8LtcGQwg9KN 7ULqffEmg8BSjvc0EXIHg== X-UI-Out-Filterresults: notjunk:1;V01:K0:6QaNYDb4qHk=:PTbTa31g+PNOPJOV5Utnmd R0wX8DZT6zeP8bmPyV75JHCOPdHVwljSZwP9kR2lrgELrNWgMtOLxuFfysyZqp+j6fyPWMbSy zld404SjLDhjhh8EUEJ0oB2yuCoSeTZccYIZciDv+UQ9lRBSaSBZqDladlfUUqyeisaW9+j9a WcvrsgQy9FW5qszqEWrgch0+mSltt91Rgh/5K2WmQyORo1SFUqoToOapgHMW1zrgWcKobvzt9 yMVh2oYHMj/FKr5pqsdNBTuVT9paT8uxoK64VlzRDRO7f5zbQ+6D40tFlwY91WWcMAtJDqeNM kr4AhineHgTtaRPcx6koJKPy8WhYbj6f19bh7e3TW8jdgDe3cWo4+fCkiHcLH5hB/K0G91JFv x80HUkSMcnRx54JNNB4vPLiLCYyRGdUUgaEad23z2wpcLtcYmHoaVeXXETGdcQXGjNOkeECh8 GLvxP/g8s1rGQurMj1fMKt0ZV0+iYMMwwrLSQC1hjosgpHoAQ2J4eBcu2fbDqYfauocA61d0F 938wy2HOxZL58uBE0zuclCel4lpnYBM28JhewrhZxjz2i5G3EJRN1+fHDGll2MaUl97eJQSQu NklX8nNCAV7K6/NKlSIeYBZJQpM+NwnHSIP5otK0BI97Xtl4Wq9IHZFXSzFAdsHMjux4C2U4B 9n/NKVQYh2bJvSLKmqtk1qWy+ZdcNephlBbI1HTiuxjSum9SfS+8LjkyNh+p7p2tGBPbwN6W0 JdS0A8z8hMG1dSwX Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday 19 February 2016 12:58:44 Murali Karicheri wrote: > SW data field in descriptor can be used by software to hold private > data for the driver. As there are 4 words available for this purpose, > use separate macros to place it or retrieve the same to/from > descriptors. Also do type cast of data types accordingly. > > Cc: Wingman Kwok > Cc: Mugunthan V N > CC: Arnd Bergmann > CC: Grygorii Strashko > CC: David Laight > Signed-off-by: Murali Karicheri Looks ok in principle. Acked-by: Arnd Bergmann > get_pkt_info(&dma_buf, &tmp, &dma_desc, ndesc); > - get_sw_data((u32 *)&buf_ptr, &buf_len, ndesc); > + /* warning!!!! We are retrieving the virtual ptr in the sw_data > + * field as a 32bit value. Will not work on 64bit machines > + */ > + buf_ptr = (void *)GET_SW_DATA0(ndesc); > + buf_len = (int)GET_SW_DATA1(desc); I would have abstracted the retrieval of a pointer again, and added the comment in the helper function once, it doesn't really need to be duplicated everywhere. Arnd