Re: [PATCH 2/4] dt-bindings: Document the Raspberry Pi Touchscreen nodes.

Eric Anholt
2017-05-16T00:03:34Z

[-- Attachment #1: Type: text/plain, Size: 2340 bytes --]

Laurent Pinchart <laurent.pinchart@ideasonboard.com> writes:

> Hi Eric,
>
> Thank you for the patch.
>
> On Thursday 11 May 2017 16:56:23 Eric Anholt wrote:
>> The Raspberry Pi 7" Touchscreen is a DPI touchscreen panel with
>> DSI->DPI bridge and touchscreen controller integrated, that connects
>> to the Raspberry Pi through its 15-pin "DSI" connector (some lines are
>> DSI, some lines are I2C).
>>
>> This device is represented in the DT as three nodes (DSI device, I2C
>> device, panel). Input will be left to a separate binding later, as it
>> will be a basic I2C client device.
>>
>> Signed-off-by: Eric Anholt <eric@anholt.net>
>> ---
>> .../raspberrypi,7inch-touchscreen-bridge.txt | 68 +++++++++++++++++++
>> .../panel/raspberrypi,7inch-touchscreen-panel.txt | 7 +++
>> 2 files changed, 75 insertions(+)
>> create mode 100644
>> Documentation/devicetree/bindings/display/bridge/raspberrypi,7inch-touchscr
>> een-bridge.txt create mode 100644
>> Documentation/devicetree/bindings/display/panel/raspberrypi,7inch-touchscre
>> en-panel.txt
>>
>> diff --git
>> a/Documentation/devicetree/bindings/display/bridge/raspberrypi,7inch-touchs
>> creen-bridge.txt
>> b/Documentation/devicetree/bindings/display/bridge/raspberrypi,7inch-touchs
>> creen-bridge.txt new file mode 100644
>> index 000000000000..a5669beaf68f
>> --- /dev/null
>> +++
>> b/Documentation/devicetree/bindings/display/bridge/raspberrypi,7inch-touchs
>> creen-bridge.txt @@ -0,0 +1,68 @@
>> +Official 7" (800x480) Raspberry Pi touchscreen panel's bridge.
>> +
>> +This DSI panel contains:
>> +
>> +- TC358762 DSI->DPI bridge
>> +- Atmel microcontroller on I2C for power sequencing the DSI bridge and
>> + controlling backlight
>> +- Touchscreen controller on I2C for touch input
>> +
>> +and this covers the TC358762 bridge and Atmel microcontroller, while
>> +../panel/raspberrypi,7inch-touchscreen-panel.txt covers the panel.
>
> The TC358762 is a standalone bridge that doesn't depend on the ATTiny
> microcontroller used by the RPI. As it's usable standalone, I believe this
> binding should be split in two.

Do you have a plan for how I would implement a driver on top of that
binding change, though? Note that we don't program the Toshiba
directly, we only send commands to the Atmel.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]