From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S939133AbdAEXN3 (ORCPT ); Thu, 5 Jan 2017 18:13:29 -0500 Received: from mout.kundenserver.de ([217.72.192.73]:64926 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756601AbdAEXNT (ORCPT ); Thu, 5 Jan 2017 18:13:19 -0500 From: Arnd Bergmann To: "Andrew F. Davis" Cc: linuxppc-dev@lists.ozlabs.org, Russell King , Miguel Ojeda Sandonis , Wolfram Sang , Richard Purdie , Benjamin Herrenschmidt , Mauro Carvalho Chehab , Ulf Hansson , Lauro Ramos Venancio , Aloisio Almeida Jr , Samuel Ortiz , Ingo Molnar , linux-pwm@vger.kernel.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: Re: [PATCH v2 6/6] [media] Only descend into directory when CONFIG_MEDIA_SUPPORT is set Date: Fri, 06 Jan 2017 00:12:13 +0100 Message-ID: <32595176.b3HvexHCfd@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: References: <20170105210158.14204-1-afd@ti.com> <4225650.R96pl5clWf@wuerfel> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:e13m3LqLNLWlC68kyYuKsLnSmFsegTOw9osTeMrYQUXewcGpP7s jgnhd9pMsR0f9i6Pe4ZvFPL38BL4VwcChSAdb6mXGGUZ8w4W9yW7zQgp5w8TW/PUdzk5d1U QyK0bGWVXdJ0ibPzcG62Xp3MANxrrFe55fRAmHY8ZYY4RzTka8leGvirNBvtwtvlc8oyQ58 mxeEQI9BOv+0p4umPKuGg== X-UI-Out-Filterresults: notjunk:1;V01:K0:yePMpDX1sPg=:pGhXaWvu0siC5NyvCXgwbK DmwtrpCPTcqdCmuySSCuOjR2zskxz+/5udvSRNCyG1oQbHdzp50fgXzhRULjjCQ9MON3vcziF saS/4lT3wDujg0aqokxm3DNnbOjYRLiW+zZv9E92ZHDURN8r+yEWTK0Z+uZWijgVYOq1BpvcU IP4qkm1viIyJPx8HjA7I4Ejy+1oBBhFW6aTss988OpwZ8tmRChNvzkKqzxFxs/Awh4BTioA3Q EQkSvLgkx6BJKzqCGiI7vZzatdr4fppR9sz3PBWMd8L9F4BEamJz5PFe1piqI7Kw8B0JRtxR2 Aeu2YIaBoUsVz5JX67AFcMlQS7u4SMjXnQCljEt1y7X2CHI76pHP2vRDHcGrtND1/EW1lrgRg e1JNjCEiQkhQEP2aEE5m/E71Zz1Gj+oebQc1+1qmWOQRVa37psHB/ZPesqySwtpLStbhuRT/d Wub56RoS1aXyocyyDjNTSwU9wMkvd6crxWdJoSsgsfoYMCGxbOmv+JjRHfdOVk6+mzUY3ESmC QUb56vGDP6vV0Qwvdyy5dVqz3yxD4FEVNUHGSiZWfaFkykidWBo96RLGmX4lQnCgDRxQhaVfG khLgk3IGhQBgNnVSctki6aMWbwFyymEK2qDKLrWhFNb73Dd97SX/YeS+Mn21zqTFm7pXXodD7 8hPRBG2mUvqpMNwXJrwMaJgptSrcnQK6zz67PahLxY1n+ngpoZ8fVAx+icGQTlavRAZhpNECx JHxhX5LVcGNIyXNl Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday, January 5, 2017 4:35:33 PM CET Andrew F. Davis wrote: > On 01/05/2017 03:42 PM, Arnd Bergmann wrote: > > On Thursday, January 5, 2017 3:01:58 PM CET Andrew F. Davis wrote: > >> @@ -109,7 +109,8 @@ obj-$(CONFIG_SERIO) += input/serio/ > >> obj-$(CONFIG_GAMEPORT) += input/gameport/ > >> obj-$(CONFIG_INPUT) += input/ > >> obj-$(CONFIG_RTC_LIB) += rtc/ > >> -obj-y += i2c/ media/ > >> +obj-y += i2c/ > >> +obj-$(CONFIG_MEDIA_SUPPORT) += media/ > >> obj-$(CONFIG_PPS) += pps/ > >> obj-y += ptp/ > >> obj-$(CONFIG_W1) += w1/ > >> > > > > This one seems wrong: if CONFIG_MEDIA_SUPPORT=m, but some I2C drivers > > inside of drivers/media/ are built-in, we will fail to enter the directory, > > see drivers/media/Makefile. > > Not sure if I see this, it looks like everything in drivers/media/ > depends on CONFIG_MEDIA_SUPPORT (directly or indirectly). If > CONFIG_MEDIA_SUPPORT is =m then all dependents should be locked out of > being built-in. > > Any bool symbol that controls compilation of source that depends on a > tristate symbol is broken and should be fixed anyway. I don't think it's this easy, we have a couple of cases where that doesn't work. I have not looked at the media example in detail, but at least it looks intentional. Note that drivers/media is rather creative with expressing dependencies. Arnd