From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753139AbcGGPmt (ORCPT ); Thu, 7 Jul 2016 11:42:49 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:55287 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753077AbcGGPml (ORCPT ); Thu, 7 Jul 2016 11:42:41 -0400 From: Arnd Bergmann To: linuxppc-dev@lists.ozlabs.org Cc: Arvind Yadav , leoli@freescale.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Removing lots of IS_ERR_VALUE abuses and compilation warning. Date: Thu, 07 Jul 2016 17:45:53 +0200 Message-ID: <3262228.FZLtnpegJr@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-22-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <1467904336-3588-1-git-send-email-arvind.yadav.cs@gmail.com> References: <1467904336-3588-1-git-send-email-arvind.yadav.cs@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:AwhQLdnVp8JDdhYQFRJya81yJVor5EviSqoQzfrvX7v4UDTqHH9 XfqkDsHEohExrMejxC936Qe2LAZ/uYvGAHGLHQimIiPA4+uJlQit47EsZowdCW/8EhhR0QW btlK97R8T/fgNYbPD5LFu6N0WMy5ON+1OfP8Hhl+wY8fV0yWHNxtMBAcH+cSRbjlX/9Qq/b Qy3GW19R9lnqmffiDd+UA== X-UI-Out-Filterresults: notjunk:1;V01:K0:v4Ac6sBQkYs=:1yjEp0tnnRQoc40KkQT1E5 4DDP6UNZNmIFLfLLRdbWrN5zYGF6bffxGVxfUJOWs/HAUVzNetr5Mp2QIjtsNzJ95Z8qQkjIp 5XfNNeG8MlEfc8LrGVQddSmSKD10nxz9wvbxc60DCCELiIOtIRRwNMWsfVxcdUwVQw/sBKv0D EWtz1ztjMBo30gemDS3Du6xoQiz5M4Yg6B02z9H7NbOJWjsE0Eskd6YU/fB23JC3bO9ACWLa/ Z2TwJ27FZv2rd33+WgJp3LCjZg5SPxkuHizAw3BnWR33Q9JpHu7zlxi67D0Ex0liK3HCQhF90 VFXzTLp6GSt/S5MScnaNlu1O9PINNemHUQLgTYw+esNExGQHQLmXXCxw0PUKALPelq/VBofW3 8yQ7Yf2+7ckYmD6OuHT02jF/A6XjVokIg/xei0fJqg0aldUiQD3LEqvdZgSpbnFmeKOTt6r3+ VN352CP89Z0RMXo/mkRMSff0w6NYEte4KQImjTRIe5ArIdNdd3/ARDfoy76qXiUduOqFnT9Ls nK7RiPG69AFVeJEf3bbuzPT0XPTb9731b+qll2womM29JdKgUADFQWzmhPWlfFy0x6i/tYW8s UIF9XcuJxISyTTTZfIp0+Nk/8WUGzZDEGWQxQKWHF7icEMfrKVFR2/hxaJ/29ANYswQx2PnH8 yQyj3oFavQt8WOW5DdAtcZXjs5DqvO4STsSHWY0a+4Sh0HwxlQRrhxmkUSCKS8PEH9NdlL6GM Z8lfinQWAym0Ofyw Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday, July 7, 2016 8:42:16 PM CEST Arvind Yadav wrote: > Passing value in IS_ERR_VALUE() is wrong, as they > pass an 'int' into a function that takes an 'unsigned long' > argument. This happens to work because the type is sign-extended > on 64-bit architectures before it gets converted into an > unsigned type. > > Passing an 'unsigned short' or 'unsigned int' > argument into IS_ERR_VALUE() is guaranteed to be broken, as are > 8-bit integers and types that are wider than 'unsigned long'. > > Any user will get compilation warning for that do not pass an > 'unsigned long' argument. > > Commit '287980e49f; - This change is alreday fixes lots of other > worst abusers. > > Signed-off-by: Arvind Yadav > Acked-by: Arnd Bergmann just notice about your submission that the changelog is whitespace damaged, you probably got the leading whitespace when you pasted a git log into the commit. Arnd