* [patch] 2.4.8-pre3 drivers/usb/storage/scsiglue.c
@ 2001-07-31 2:11 Keith Owens
2001-07-31 5:50 ` Matthew Dharm
0 siblings, 1 reply; 3+ messages in thread
From: Keith Owens @ 2001-07-31 2:11 UTC (permalink / raw)
To: Matthew Dharm; +Cc: linux-kernel
Trivial patch to remove warning message.
Index: 8-pre3.1/drivers/usb/storage/scsiglue.c
--- 8-pre3.1/drivers/usb/storage/scsiglue.c Tue, 31 Jul 2001 11:09:45 +1000 kaos (linux-2.4/y/b/2_scsiglue.c 1.4.2.1 644)
+++ 8-pre3.1(w)/drivers/usb/storage/scsiglue.c Tue, 31 Jul 2001 12:07:28 +1000 kaos (linux-2.4/y/b/2_scsiglue.c 1.4.2.1 644)
@@ -249,7 +249,7 @@ static int bus_reset( Scsi_Cmnd *srb )
for (i = 0; i < us->pusb_dev->actconfig->bNumInterfaces; i++) {
struct usb_interface *intf =
&us->pusb_dev->actconfig->interface[i];
- struct usb_device_id *id;
+ const struct usb_device_id *id;
/* if this is an unclaimed interface, skip it */
if (!intf->driver) {
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [patch] 2.4.8-pre3 drivers/usb/storage/scsiglue.c
2001-07-31 2:11 [patch] 2.4.8-pre3 drivers/usb/storage/scsiglue.c Keith Owens
@ 2001-07-31 5:50 ` Matthew Dharm
2001-07-31 6:21 ` Keith Owens
0 siblings, 1 reply; 3+ messages in thread
From: Matthew Dharm @ 2001-07-31 5:50 UTC (permalink / raw)
To: Keith Owens; +Cc: linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1308 bytes --]
Hrm... there was a good reason at one point why this shouldn't be const....
Oh yeah... it's not const. id gets assigned a few lines down.
Or does the const keywork refer only to the struct, not to the pointer? If
that's the case, then the keyword should be there....
Matt Dharm
On Tue, Jul 31, 2001 at 12:11:21PM +1000, Keith Owens wrote:
> Trivial patch to remove warning message.
>
> Index: 8-pre3.1/drivers/usb/storage/scsiglue.c
> --- 8-pre3.1/drivers/usb/storage/scsiglue.c Tue, 31 Jul 2001 11:09:45 +1000 kaos (linux-2.4/y/b/2_scsiglue.c 1.4.2.1 644)
> +++ 8-pre3.1(w)/drivers/usb/storage/scsiglue.c Tue, 31 Jul 2001 12:07:28 +1000 kaos (linux-2.4/y/b/2_scsiglue.c 1.4.2.1 644)
> @@ -249,7 +249,7 @@ static int bus_reset( Scsi_Cmnd *srb )
> for (i = 0; i < us->pusb_dev->actconfig->bNumInterfaces; i++) {
> struct usb_interface *intf =
> &us->pusb_dev->actconfig->interface[i];
> - struct usb_device_id *id;
> + const struct usb_device_id *id;
>
> /* if this is an unclaimed interface, skip it */
> if (!intf->driver) {
--
Matthew Dharm Home: mdharm-usb@one-eyed-alien.net
Maintainer, Linux USB Mass Storage Driver
I'm a pink gumdrop! How can anything be worse?!!
-- Erwin
User Friendly, 10/4/1998
[-- Attachment #2: Type: application/pgp-signature, Size: 232 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [patch] 2.4.8-pre3 drivers/usb/storage/scsiglue.c
2001-07-31 5:50 ` Matthew Dharm
@ 2001-07-31 6:21 ` Keith Owens
0 siblings, 0 replies; 3+ messages in thread
From: Keith Owens @ 2001-07-31 6:21 UTC (permalink / raw)
To: Matthew Dharm; +Cc: linux-kernel
On Mon, 30 Jul 2001 22:50:51 -0700,
Matthew Dharm <mdharm-kernel@one-eyed-alien.net> wrote:
>Or does the const keywork refer only to the struct, not to the pointer? If
>that's the case, then the keyword should be there....
const refers to the structure, not the pointer to the structure.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2001-07-31 6:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2001-07-31 2:11 [patch] 2.4.8-pre3 drivers/usb/storage/scsiglue.c Keith Owens
2001-07-31 5:50 ` Matthew Dharm
2001-07-31 6:21 ` Keith Owens
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox