public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Amadeusz Sławiński" <amadeuszx.slawinski@linux.intel.com>
To: Jerome Brunet <jbrunet@baylibre.com>,
	Mark Brown <broonie@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Takashi Iwai <tiwai@suse.com>, Jaroslav Kysela <perex@perex.cz>
Cc: alsa-devel@alsa-project.org, linux-sound@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] ALSA: pcm: add support for 128kHz sample rate
Date: Mon, 1 Jul 2024 10:50:02 +0200	[thread overview]
Message-ID: <326792b9-e706-4ab0-a1e8-cc48943e357d@linux.intel.com> (raw)
In-Reply-To: <20240628122429.2018059-2-jbrunet@baylibre.com>

On 6/28/2024 2:23 PM, Jerome Brunet wrote:
> The usual sample rate possible on an SPDIF link are
> 32k, 44.1k, 48k, 88.2k, 96k, 172.4k and 192k.
> 
> With higher bandwidth variant, such as eARC, and the introduction of 8
> channels mode, the spdif frame rate may be multiplied by 4. This happens
> when the interface use an IEC958_SUBFRAME format.
> 
> The spdif 8 channel mode rate list is:
> 128k, 176.4k, 192k, 352.8k, 384k, 705.4k and 768k.
> 
> All are already supported by ASLA expect for the 128kHz one.
> Add support for it but do not insert it the SNDRV_PCM_RATE_8000_192000
> macro. Doing so would silently add 128k support to a lot of HW which
> probably do not support it.
> 
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
> ---

 From what I remember the recommendation is to not add new rates, but 
use SNDRV_PCM_RATE_KNOT for all rates not included already.


  parent reply	other threads:[~2024-07-01  8:50 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-28 12:23 [PATCH 0/3] ALSA: update sample rate definition for eARC Jerome Brunet
2024-06-28 12:23 ` [PATCH 1/3] ALSA: pcm: add support for 128kHz sample rate Jerome Brunet
2024-06-29 23:29   ` kernel test robot
2024-06-30  6:53     ` Jerome Brunet
2024-07-01 14:04       ` Takashi Iwai
2024-06-30  1:10   ` kernel test robot
2024-07-01  8:50   ` Amadeusz Sławiński [this message]
2024-07-01 14:07     ` Takashi Iwai
2024-07-08 13:34       ` Jerome Brunet
2024-07-08 14:00         ` Takashi Iwai
2024-08-09  8:29           ` Jerome Brunet
2024-08-09  8:42             ` Takashi Iwai
2024-08-09 23:27               ` Mark Brown
2024-06-28 12:23 ` [PATCH 2/3] ALSA: IEC958 definition for consumer status channel update Jerome Brunet
2024-06-28 12:23 ` [PATCH 3/3] ASoC: spdif: extend supported rates to 768kHz Jerome Brunet
2024-06-28 12:34   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=326792b9-e706-4ab0-a1e8-cc48943e357d@linux.intel.com \
    --to=amadeuszx.slawinski@linux.intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=jbrunet@baylibre.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox