public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: Toshiyuki Okajima <toshi.okajima@jp.fujitsu.com>
Cc: dhowells@redhat.com, keyrings@linux-nfs.org, security@kernel.org,
	linux-security-module@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1][BUG][TAKE2] KEYRINGS: find_keyring_by_name() can gain the freed keyring
Date: Mon, 26 Apr 2010 15:47:48 +0100	[thread overview]
Message-ID: <32722.1272293268@redhat.com> (raw)
In-Reply-To: <20100426232234.5c210566.toshi.okajima@jp.fujitsu.com>

Toshiyuki Okajima <toshi.okajima@jp.fujitsu.com> wrote:

> OK. I understand. So, your patch looks fine to me.
> ---
> Once find_keyring_by_name() returns -ENOKEY, the new user creates a
> new key. So, both the deleting key and the new key may exist.
> Therefore at next find_keyring_by_name() call, we should find the new
> key and ignore the deleting key.
> ---
> 
> Today, I tested your patch and any problem didn't happen.
> So, I rewrote your patch. Here you are:

Thanks.

Note that the vertical lines in the right-hand column of your timeline don't
seem to line up correctly.  Are you editing it in an editor with a
proportional font?

David

  reply	other threads:[~2010-04-26 14:47 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-22  7:37 [PATCH 1/1][BUG][IMPORTANT] KEYRINGS: find_keyring_by_name() can gain the freed keyring Toshiyuki Okajima
2010-04-22 10:16 ` David Howells
2010-04-23 10:45   ` Toshiyuki Okajima
2010-04-23 10:51     ` [PATCH 1/1][BUG][TAKE2] " Toshiyuki Okajima
2010-04-23 11:33       ` David Howells
2010-04-23 15:23         ` Toshiyuki Okajima
2010-04-23 15:52           ` David Howells
2010-04-24  0:32             ` 岡嶋　寿行
2010-04-26 14:22             ` Toshiyuki Okajima
2010-04-26 14:47               ` David Howells [this message]
2010-04-26 10:57           ` David Howells
2010-04-26 14:42             ` Toshiyuki Okajima
2010-04-29 11:23               ` Toshiyuki Okajima

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=32722.1272293268@redhat.com \
    --to=dhowells@redhat.com \
    --cc=keyrings@linux-nfs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=security@kernel.org \
    --cc=toshi.okajima@jp.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox