From: Arnd Bergmann <arnd@arndb.de>
To: Robin van der Gracht <robin@protonic.nl>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Herring <robh@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Miguel Ojeda Sandonis <miguel.ojeda.sandonis@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] auxdisplay: ht16k33: select CONFIG_FB_SYS_FOPS
Date: Fri, 25 Nov 2016 09:30:07 +0100 [thread overview]
Message-ID: <3275301.7nJ4tt8fXD@wuerfel> (raw)
In-Reply-To: <20161125085004.74c9acb5@erd979>
On Friday, November 25, 2016 8:50:04 AM CET Robin van der Gracht wrote:
>
> Thanks for reporting this. You are right about the missing helper.
> However, the fb_ops struct uses several helpers which are all missing.
>
> static struct fb_ops ht16k33_fb_ops = {
> .owner = THIS_MODULE,
> .fb_read = fb_sys_read,
> .fb_write = fb_sys_write,
> .fb_fillrect = sys_fillrect,
> .fb_copyarea = sys_copyarea,
> .fb_imageblit = sys_imageblit,
> .fb_mmap = ht16k33_mmap,
> };
>
> HT16K33 should also select:
> FB_CFB_FILLRECT
> FB_CFB_COPYAREA
> FB_CFB_IMAGEBLIT
>
Ah right. I had not run into those so far during randconfig
testing, probably because there is usually at least one other
framebuffer enabled that selects them.
Can you submit a patch to add all those?
Arnd
prev parent reply other threads:[~2016-11-25 8:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-23 13:06 [PATCH] auxdisplay: ht16k33: select CONFIG_FB_SYS_FOPS Arnd Bergmann
2016-11-25 7:50 ` Robin van der Gracht
2016-11-25 8:30 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3275301.7nJ4tt8fXD@wuerfel \
--to=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=robh@kernel.org \
--cc=robin@protonic.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox