public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH bpf-next] bpf: Fix bpf_seq_read docs for increased buffer size
@ 2025-12-07  9:10 T.J. Mercier
  2025-12-07 17:42 ` Yonghong Song
  2025-12-14  3:00 ` patchwork-bot+netdevbpf
  0 siblings, 2 replies; 4+ messages in thread
From: T.J. Mercier @ 2025-12-07  9:10 UTC (permalink / raw)
  To: menglong.dong, Yonghong Song, Alexei Starovoitov, Daniel Borkmann,
	Andrii Nakryiko, Martin KaFai Lau, Eduard Zingerman, Song Liu,
	John Fastabend, KP Singh, Stanislav Fomichev, Hao Luo, Jiri Olsa
  Cc: T.J. Mercier, bpf, linux-kernel

Commit af65320948b8 ("bpf: Bump iter seq size to support BTF
representation of large data structures") increased the fixed buffer
size from PAGE_SIZE to PAGE_SIZE << 3, but the docs for the function
didn't get updated at the same time. Update them.

Signed-off-by: T.J. Mercier <tjmercier@google.com>
---
 kernel/bpf/bpf_iter.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/bpf/bpf_iter.c b/kernel/bpf/bpf_iter.c
index eec60b57bd3d..4b58d56ecab1 100644
--- a/kernel/bpf/bpf_iter.c
+++ b/kernel/bpf/bpf_iter.c
@@ -86,7 +86,7 @@ static bool bpf_iter_support_resched(struct seq_file *seq)
 
 /* bpf_seq_read, a customized and simpler version for bpf iterator.
  * The following are differences from seq_read():
- *  . fixed buffer size (PAGE_SIZE)
+ *  . fixed buffer size (PAGE_SIZE << 3)
  *  . assuming NULL ->llseek()
  *  . stop() may call bpf program, handling potential overflow there
  */
-- 
2.52.0.223.gf5cc29aaa4-goog


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH bpf-next] bpf: Fix bpf_seq_read docs for increased buffer size
  2025-12-07  9:10 [PATCH bpf-next] bpf: Fix bpf_seq_read docs for increased buffer size T.J. Mercier
@ 2025-12-07 17:42 ` Yonghong Song
  2025-12-08 23:41   ` T.J. Mercier
  2025-12-14  3:00 ` patchwork-bot+netdevbpf
  1 sibling, 1 reply; 4+ messages in thread
From: Yonghong Song @ 2025-12-07 17:42 UTC (permalink / raw)
  To: T.J. Mercier, menglong.dong, Alexei Starovoitov, Daniel Borkmann,
	Andrii Nakryiko, Martin KaFai Lau, Eduard Zingerman, Song Liu,
	John Fastabend, KP Singh, Stanislav Fomichev, Hao Luo, Jiri Olsa
  Cc: bpf, linux-kernel



On 12/7/25 1:10 AM, T.J. Mercier wrote:
> Commit af65320948b8 ("bpf: Bump iter seq size to support BTF
> representation of large data structures") increased the fixed buffer
> size from PAGE_SIZE to PAGE_SIZE << 3, but the docs for the function
> didn't get updated at the same time. Update them.
>
> Signed-off-by: T.J. Mercier <tjmercier@google.com>

Acked-by: Yonghong Song <yonghong.song@linux.dev>


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH bpf-next] bpf: Fix bpf_seq_read docs for increased buffer size
  2025-12-07 17:42 ` Yonghong Song
@ 2025-12-08 23:41   ` T.J. Mercier
  0 siblings, 0 replies; 4+ messages in thread
From: T.J. Mercier @ 2025-12-08 23:41 UTC (permalink / raw)
  To: Yonghong Song
  Cc: menglong.dong, Alexei Starovoitov, Daniel Borkmann,
	Andrii Nakryiko, Martin KaFai Lau, Eduard Zingerman, Song Liu,
	John Fastabend, KP Singh, Stanislav Fomichev, Hao Luo, Jiri Olsa,
	bpf, linux-kernel

On Mon, Dec 8, 2025 at 2:42 AM Yonghong Song <yonghong.song@linux.dev> wrote:
>
>
>
> On 12/7/25 1:10 AM, T.J. Mercier wrote:
> > Commit af65320948b8 ("bpf: Bump iter seq size to support BTF
> > representation of large data structures") increased the fixed buffer
> > size from PAGE_SIZE to PAGE_SIZE << 3, but the docs for the function
> > didn't get updated at the same time. Update them.
> >
> > Signed-off-by: T.J. Mercier <tjmercier@google.com>
>
> Acked-by: Yonghong Song <yonghong.song@linux.dev>

Thanks!

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH bpf-next] bpf: Fix bpf_seq_read docs for increased buffer size
  2025-12-07  9:10 [PATCH bpf-next] bpf: Fix bpf_seq_read docs for increased buffer size T.J. Mercier
  2025-12-07 17:42 ` Yonghong Song
@ 2025-12-14  3:00 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2025-12-14  3:00 UTC (permalink / raw)
  To: T.J. Mercier
  Cc: menglong.dong, yonghong.song, ast, daniel, andrii, martin.lau,
	eddyz87, song, john.fastabend, kpsingh, sdf, haoluo, jolsa, bpf,
	linux-kernel

Hello:

This patch was applied to bpf/bpf-next.git (master)
by Alexei Starovoitov <ast@kernel.org>:

On Sun,  7 Dec 2025 01:10:04 -0800 you wrote:
> Commit af65320948b8 ("bpf: Bump iter seq size to support BTF
> representation of large data structures") increased the fixed buffer
> size from PAGE_SIZE to PAGE_SIZE << 3, but the docs for the function
> didn't get updated at the same time. Update them.
> 
> Signed-off-by: T.J. Mercier <tjmercier@google.com>
> 
> [...]

Here is the summary with links:
  - [bpf-next] bpf: Fix bpf_seq_read docs for increased buffer size
    https://git.kernel.org/bpf/bpf-next/c/6f0b824a61f2

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2025-12-14  3:03 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-07  9:10 [PATCH bpf-next] bpf: Fix bpf_seq_read docs for increased buffer size T.J. Mercier
2025-12-07 17:42 ` Yonghong Song
2025-12-08 23:41   ` T.J. Mercier
2025-12-14  3:00 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox