Re: [PATCH] VFS autmounter support v2

viro
2003-06-18T20:45:49Z

On Wed, Jun 18, 2003 at 03:20:15PM +0100, David Howells wrote:
>
> Hi Linus, Al,
>
> I've revised my patch to make sure a process in one namespace doesn't change
> the topology of another namespace (kern_automount() will return an error in
> that case, as does (u)mount). As a bonus, check_mnt() has been simplified to
> take account of the namespace pointer now in vfsmount.

You _still_ don't get it. OK, the last time: kern_automount() will
always do the same thing, no matter which namespace we are it. It
might be OK for AFS, but it's definitely unfit for any other use.

No amount of "use of (u)mount to rearrange topology" will help here -
with your code you have dentry marked, and stepping on it (in any
namespace, in any instance of that fs in a namespace) will always do
the same thing. And that is Wrong(tm).