From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932450AbdCIOot (ORCPT ); Thu, 9 Mar 2017 09:44:49 -0500 Received: from mailout3.samsung.com ([203.254.224.33]:51798 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754781AbdCIOoY (ORCPT ); Thu, 9 Mar 2017 09:44:24 -0500 X-AuditID: b6c32a38-f79f06d000001a72-55-58c169fee2a9 From: Bartlomiej Zolnierkiewicz To: Russell King - ARM Linux Cc: Sergei Shtylyov , Sekhar Nori , Arnd Bergmann , Dmitry Eremin-Solenikov , Kevin Hilman , linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org, Olof Johansson , linux-arm-kernel@lists.infradead.org Subject: Re: [RESEND PATCH] arm: assabet_defconfig: disable IDE subsystem Date: Thu, 09 Mar 2017 15:42:49 +0100 Message-id: <3285453.g1rFzTv5DW@amdc3058> User-Agent: KMail/4.13.3 (Linux/3.13.0-96-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: <20170309135714.GJ21222@n2100.armlinux.org.uk> MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset=us-ascii X-Brightmail-Tracker: H4sIAAAAAAAAA01Se0hTURz23O1u1+Xkuqn9SEpaVCjmAwwuGVrQ49oLSQKLwlbeVHyNXbUU wgzXdBS01VyYmKJBDakxNd+vGVtYWc4yE7OnYqkJpZhaVtu9gv995/y+x+87HEIgq8fXEamZ 2Yw6U5muEEmEj3qCwrYtp3YnhPdaRNQfg11MGb7MCKgFbT1GWT8P4pS96RNGDbSUiyibsR1R ndcsGNX75qeIemYeFu+S0AOD/QJ6adGA6JkhjZj+YPyL0c1l78R0XU0B/erJZZx2DDVi9E/r hjjPE5KdSUx6ai6jDos+LUmpM2xQLfpdsJkm8EvI6aNDngSQkXBfc1fMYX94OfpQpEMSQkY2 IajW/0bcQYuBSTuBrSiq62xCblCO4Pe8k2fNIaiyvBe5WCJyB+i1ZuTCvv8V9u5ZoQsLSCcG 5Ya9OkQQcjIWLIshrmshuRkaum65pVIyCFp7Wtwr+ZEHoL5D6w72JKOgbfYpz/GBXzdGectA 6Og04hwOgef2B+59gBwVQ9VYMe7KAnI9WLsEXIE9MPlRx1eWwzdHPY8DwLw8zJc0IWhcAs6n DoG59TpPioIeRz8f5g3f567y/lIoviLjKDR03FtCHN4NtU23ce59SjAYqqnCr6PAslUdylZ1 KFvVoRIJzMifUbEZyQwboYoMZZUZbE5mcujZrAwrcv+lYKoJtfUdsiGSQAovKSnvSpDhylw2 L8OGgBAofKVfme4EmTRJmZfPqLMS1TnpDGtDAYRQsVaKh+sTZGSyMptJYxgVo16ZYoTnuktI lxgmLM+PfEukjVQsn7o5T457RPSZDmrm4hP1BUfG1xhuez0eCbcbj9fGDF88OZZTIj86fSzt 9VS1dX+s3kOvwWILrFudW16Uxomiz6nGLIf3eRfFt3s4MzduWijdfrigyhTDFnWdCci3h09O V1T+OGikNM13QgoLh843N0yxDoWQTVFGBAvUrPIfCy1pMEcDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrOIsWRmVeSWpSXmKPExsVy+t9jQd2/mQcjDP4sMrb4O+kYu8WkJ++Z LX62b2Gy2PT4GqvFsR2PmCwu75rDZnFo6l5Gi/29G5gsTl3/zGZxZtUtdgcuj8vXLjJ7/P41 idHj/Y1Wdo8HU/8zeeycdZfdY/OSeo8rJ5pYPY7f2M7k8XmTXABnlJtNRmpiSmqRQmpecn5K Zl66rVJoiJuuhZJCXmJuqq1ShK5vSJCSQlliTimQZ2SABhycA9yDlfTtEtwyNk+SK/glWnFo +gvWBsZLgl2MnBwSAiYSizcfYoGwxSQu3FvP1sXIxSEkMItR4nj/LRYI5yujxJ9fK9hBqtgE rCQmtq9iBLFFgLqPHfwCVsQscIVJYtbylUxdjBwcwgKeEht+6YDUsAioSmw9MIMNxOYV0JTY fXgX2BxRAS+JLfvamUBsTgFriT1fTkNt3sooceHkD0aIBkGJH5PvgZ3HLCAvsW//VFYIW0ti /c7jTBMYge5EKJuFpGwWkrIFjMyrGCVSC5ILipPScw3zUsv1ihNzi0vz0vWS83M3MYIj9ZnU DsaDu9wPMQpwMCrx8AoIH4gQYk0sK67MPcQowcGsJML7MvVghBBvSmJlVWpRfnxRaU5q8SFG U6APJzJLiSbnA5NIXkm8oYm5ibmxgYW5paWJkZI4b+PsZ+FCAumJJanZqakFqUUwfUwcnFIN jNqdlxyPBX6c9Ds8Z8rK3PXlzysmeNlLrJg4odk07ofDUjcewWmuJy/fCWQVDGpMOX36hHF0 lOhmxjOFjqVfDjTOUNrv+3JRcFP0j+jLs/V1Z7yTat5zeu6l4/5SwkaZbm5KGlFfK75N5Fwk b5zSHr/r5PvJJy8rP/ji975ctvzPV5ft20Ou+yqxFGckGmoxFxUnAgD6UGr76gIAAA== X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170309144309epcas1p17e601ea2747d5587e4fecf61cc670812 X-Msg-Generator: CA X-Sender-IP: 203.254.230.26 X-Local-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRvsgrzshLHsoITsnpAbU2VuaW9yIFNvZnR3YXJlIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRtTYW1zdW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBF?= =?UTF-8?B?bmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 101P X-HopCount: 7 X-CMS-RootMailID: 20170309144309epcas1p17e601ea2747d5587e4fecf61cc670812 X-RootMTR: 20170309144309epcas1p17e601ea2747d5587e4fecf61cc670812 References: <1467991490-24895-1-git-send-email-b.zolnierkie@samsung.com> <20170309135714.GJ21222@n2100.armlinux.org.uk> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Thursday, March 09, 2017 01:57:15 PM Russell King - ARM Linux wrote: > On Thu, Mar 09, 2017 at 03:24:56PM +0300, Sergei Shtylyov wrote: > > On 03/09/2017 03:20 PM, Sekhar Nori wrote: > > > > >[...] > > > > >>>diff --git a/arch/arm/mach-davinci/board-dm644x-evm.c > > >>>b/arch/arm/mach-davinci/board-dm644x-evm.c > > >>>index 023480b75244..60a1f23890cd 100644 > > >>>--- a/arch/arm/mach-davinci/board-dm644x-evm.c > > >>>+++ b/arch/arm/mach-davinci/board-dm644x-evm.c > > >>>@@ -744,7 +744,7 @@ static int davinci_phy_fixup(struct phy_device > > >>>*phydev) > > >>> return 0; > > >>> } > > >>> > > >>>-#define HAS_ATA IS_ENABLED(CONFIG_BLK_DEV_PALMCHIP_BK3710) > > >>>+#define HAS_ATA IS_ENABLED(CONFIG_PATA_BK3710) > > >> > > >> I think it would be more correct to check for both libata and IDE > > >>drivers here... > > > > > >As I understand, the plan is to remove the IDE driver soon. > > > > I'm not sure DaveM would support any removals in drivers/ide/. He has > > explicitly expressed his will to maintain the IDE driuver forever. > > As I keep saying, there are ARM machines where the IDE driver works but > the PATA driver doesn't. EBSA110's PCMCIA slots for instance. Please be more specific, I'll be happy to help with migrating this machines to libata PATA. BTW the example you're giving has never worked with the old IDE driver in the upstream kernel. > Yes, it's very obscure - but what it comes down to is the silly way the > "ISA" IO is handled on the platform (which depends whether it's an 8-bit > or 16-bit ISA-style peripheral.) The old IDE CS driver _could_ be bent > to work via a patch like this: > > ARM: EBSA110: Enable 16-bit IO type for ide-iops > > diff --git a/arch/arm/Makefile b/arch/arm/Makefile > index 047a20780fc1..2eb501d6b5fe 100644 > --- a/arch/arm/Makefile > +++ b/arch/arm/Makefile > @@ -217,7 +217,8 @@ ifeq ($(CONFIG_ARCH_EBSA110),y) > # This is what happens if you forget the IOCS16 line. > # PCMCIA cards stop working. > CFLAGS_3c589_cs.o :=-DISA_SIXTEEN_BIT_PERIPHERAL > -export CFLAGS_3c589_cs.o > +CFLAGS_ide-io-std.o :=-DISA_SIXTEEN_BIT_PERIPHERAL > +export CFLAGS_3c589_cs.o CFLAGS_ide-io-std.o > endif As I've already explained in the past, the proper fix for the problem (for both old IDE and libata) is to define custom transport ops in ide-cs.c/ata_pcmcia.c and use them on affected platforms. > # The byte offset of the kernel image in RAM from the start of RAM. > > but the PATA driver is much harder. There are a lot examples of using your own transport operations in existing code (i.e. pata_octeon_cf.c or drivers/ata/sata_rcar.c). Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics