Re: [20/80] ALSA: lx6464es - fix device communication via command bus

H. Peter Anvin
2011-12-07T18:01:22Z

On 12/07/2011 09:47 AM, Linus Torvalds wrote:
>
> Ingo, Peter, Thomas? Comments?
>

I agree in principle, although I am really not happy about the idea of
disallowing 64-bit writes from device drivers that haven't explicitly
indicated they won't support it.

However, I would *also* like if more drivers would explicitly specify
the transfer size they expect. Right now, that is done though a set of
functions whose name are a bit of a mismatch to the others:
__iowrite{32,64}_copy(), which probably should be renamed
memcpy_toio{32,64}() and augmented with matching memcpy_fromio{32,64}()
functions.

What do you think?

-hpa

--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.