From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1037431AbdE0BTM (ORCPT ); Fri, 26 May 2017 21:19:12 -0400 Received: from gloria.sntech.de ([95.129.55.99]:50808 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1948796AbdEZWTn (ORCPT ); Fri, 26 May 2017 18:19:43 -0400 From: Heiko Stuebner To: David Wu Cc: linus.walleij@linaro.org, huangtao@rock-chips.com, dianders@chromium.org, linux-rockchip@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/4] Add iomux-route switching support Date: Sat, 27 May 2017 00:19:26 +0200 Message-ID: <3296473.EV6dOggqEx@phil> User-Agent: KMail/5.2.3 (Linux/4.9.0-2-amd64; KDE/5.28.0; x86_64; ; ) In-Reply-To: <1495783223-28857-1-git-send-email-david.wu@rock-chips.com> References: <1495783223-28857-1-git-send-email-david.wu@rock-chips.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi David, Am Freitag, 26. Mai 2017, 15:20:19 CEST schrieb David Wu: > The rk3228, rk3328, rk3399 have an interesting new feature, > some things like one specific uart can use multiple pins to > output data, but control of that seems to be split. The actual > pin config is identical for all pins - each needs to be configured > to function 2. > > Use one pin of a specifc group to be set to its special pinmux function, > then configure the corresponding routing bits. If the pinmux setting is > wrong for that pin the ip block won't work correctly anyway. the approach looks nice now, the whole series Reviewed-by: Heiko Stuebner Thanks Heiko > David Wu (4): > pinctrl: rockchip: Add iomux-route switching support > pinctrl: rockchip: Add iomux-route switching support for rk3228 > pinctrl: rockchip: Add iomux-route switching support for rk3328 > pinctrl: rockchip: Add iomux-route switching support for rk3399 > > drivers/pinctrl/pinctrl-rockchip.c | 321 ++++++++++++++++++++++++++++++++++++- > 1 file changed, 320 insertions(+), 1 deletion(-) > >