From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753555AbcFJWSo (ORCPT <rfc822;w@1wt.eu>);
	Fri, 10 Jun 2016 18:18:44 -0400
Received: from mout.kundenserver.de ([212.227.17.10]:56555 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753413AbcFJWSN (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 10 Jun 2016 18:18:13 -0400
From: Arnd Bergmann <arnd@arndb.de>
To: y2038@lists.linaro.org
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
        Deepa Dinamani <deepa.kernel@gmail.com>,
        "Theodore Ts'o" <tytso@mit.edu>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Andreas Dilger <adilger.kernel@dilger.ca>,
        Al Viro <viro@zeniv.linux.org.uk>,
        linux-fsdevel <linux-fsdevel@vger.kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        "linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>
Subject: Re: [Y2038] [PATCH 02/21] fs: ext4: Use current_fs_time() for inode timestamps
Date: Sat, 11 Jun 2016 00:19:17 +0200
Message-ID: <3299877.khhcQSIs8Z@wuerfel>
User-Agent: KMail/5.1.3 (Linux/4.4.0-22-generic; KDE/5.18.0; x86_64; ; )
In-Reply-To: <CA+55aFx7ES7D_9uVL3T1htJj6onQP2Z2TrDqTG+Qd9AuHnVf-g@mail.gmail.com>
References: <1465448705-25055-1-git-send-email-deepa.kernel@gmail.com> <1465448705-25055-3-git-send-email-deepa.kernel@gmail.com> <CA+55aFx7ES7D_9uVL3T1htJj6onQP2Z2TrDqTG+Qd9AuHnVf-g@mail.gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:jeXRyKhubv3NR/nLTMhrcuzL+NLdpWUO0eZKCJFwGiEazudmsRI
 vZwui7Z/88bFFDqR1yCDa1LT50sLtd+a/H6u3lJ2SBP9KoTPbaCimTbkagPFT9ushQCkQSu
 HI6vYoYs/yQdqzSaAG0TSlMARZ38/pBBFoq08P83C6BPJv35npo1K4afar9JeU396Q96o8y
 U7FqiG0Z0x3aWqvSGI3JA==
X-UI-Out-Filterresults: notjunk:1;V01:K0:wWbgryZuEgg=:Tjubt0CCFpY4vNgrjef5zj
 kdDPxA//XPqsI9rkixjRl/P/85dNsFDDNHclUwU+gSPq59tAkuV6kfPXAQDMZhXLOPR1co/Xk
 iuwLo/wCXffm4XpB34XY+q83+iCajQBpi71wj+/NK9hNkFWT3lETaTQv3oD4D3SCcCfcNfQnv
 QyOLSFSuBcR7e/+1NVXE9GyhmxdlP9ThEEZ5Z9a7y8jMvye6q4GEdfbOqxja2VQKWVsyUz3/L
 w7Lmaxo7Pwg0PJA42xxFfb2G3VlFI2VmSeN8Ax8JVoMLfScEyvQLoHElPuY/WBRNdQKpVcrpy
 o+X+vQK+BcOZk3f/xjccxPXSjisRUQNtC1DsMAjvF+WhuuOk9XLN67VYzwxqSIjJw2CIgjB2u
 A0HCSmH1nAqdbpHs4o/yTHUVzt5BhcMmpZNpoMdZn10TA5Qmjw/TzzPtbjZiw2tp5p7alzyhm
 LQ3bbJLvvK78KTKODzH/AYymhLVpP4v+j8LCAIVDFyhvcgWH3qeKGoFePHSRyHhFw1QWLw0EX
 ZCM99Bb0/wgvJbEaJ+JxNgop8ScHSAzayVFN2Rsvj6ZbYOHtgNZcyu81Pwhd/hteh4FTtxNRi
 DrvHRw1AAiEiYGfeYU4OBEn0YW6J9m/wWIVyggv1kZu9BTg0P5rjLoDzB61ExAc/mZX1pTzJV
 0IZ5Ca0FuC4ghQ54CFEB9ABc35RdoDJLxQnJZwbx5MGsRGD05n6I6gg9fRns3vJWiRqdGYncX
 iUHaC9vCdEYsWtNc
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thursday, June 9, 2016 11:45:01 AM CEST Linus Torvalds wrote:
> On Wed, Jun 8, 2016 at 10:04 PM, Deepa Dinamani <deepa.kernel@gmail.com> wrote:
> > CURRENT_TIME_SEC and CURRENT_TIME are not y2038 safe.
> > current_fs_time() will be transitioned to be y2038 safe
> > along with vfs.
> >
> > current_fs_time() returns timestamps according to the
> > granularities set in the super_block.
> 
> All existing users and all the ones in this patch (and the others too,
> although I didn't go through them very carefully) really would prefer
> just passing in the inode directly, rather than the superblock.
> 
> So I don't want to add more users of this broken interface.  It was a
> mistake to use the superblock. The fact that the time granularity
> exists there is pretty much irrelevant. If every single user wants to
> use an inode pointer, then that is what the function should get.

I guess it would help to give the function a new name in the process,
if only to avoid possible conflicts. That new name of course needs to
be at least as intuitive as the old one. How about

struct timespec fs_timestamp(struct inode *);

? 

	Arnd