From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0FF6A24A069 for ; Mon, 22 Dec 2025 21:31:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766439078; cv=none; b=dughD346MhFaKwc8UXPq11aC7SAmEMZ2bPGH4zr1RYrkGynFva3ukQ9/fudE85Gt2T5k1WQbd+8WsIpSXle9Cfx8Ce0Khc8YFJg9uamAWs0PjhezG2ziKCUjONjaCwZhVn38uBWwnY5gt0vevTPWZjcoMC7xQudvsfU7nCcPzFc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766439078; c=relaxed/simple; bh=pQIkPhGyb9jlQ6EGYpjCCAdoWgK9CoA6lbOv51Q5hc4=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=sLVRoJ3+6HshbUIx42/ho7YzXTjHJ4SgeZZAO1whGnUhw03qMRJZnUgcO49hIOXu6aGjKRPxPWlk4UPhEZywBQHg4I6A0/WPYJSeb2cJTxpJp4+9JWq/0ZkR//NYx8SgSYJbPaqfYgStDeEpvXqDTteQ0IQ1Q6WUkD+IIq5bNdA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=cOsgyog9; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="cOsgyog9" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-47789cd2083so23285705e9.2 for ; Mon, 22 Dec 2025 13:31:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1766439074; x=1767043874; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:organization :references:in-reply-to:date:cc:to:from:subject:message-id:from:to :cc:subject:date:message-id:reply-to; bh=pQIkPhGyb9jlQ6EGYpjCCAdoWgK9CoA6lbOv51Q5hc4=; b=cOsgyog9+Yjvlly7GOWIAuv50SCEALtTK1wjAVbwvJZoIHic9p2Sa76Cajon3dW9wp k45x3ApRsMyQoG/WkIPRCu9K7aJ6HlC9SzBAkO8+s+mKpYvkbky73t4crHVKS1Zsc3+g IrL3/fQ6pXXbdpHK97YmC45c4Gb2imaE6yXVltJ8c4fb55b/gHO703oKtaMDzy3tJF4e qi9hLoAbhEP6+jTgTeSOt2hKf4b2FhVx/b4d7ahqxX8vQ+zvE7APyvOvBBpoQlXM+A8L j4es3dfluBwi2J3gyAPwCToEtaL0N8kRu+JOo7itQklevbXhI5k7SzW32O9FEPKM3pBz DBgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766439074; x=1767043874; h=mime-version:user-agent:content-transfer-encoding:organization :references:in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=pQIkPhGyb9jlQ6EGYpjCCAdoWgK9CoA6lbOv51Q5hc4=; b=scaxjKXZHd99B9mSZWFy2PbqWWLU+i/0ZoTRBGStQ8C3h5eG5BLpcbHeCwKHo26Y4u AWVCIEDml5eSd8WyqbJ67JjbvRkJIoYpmqMl7MFKpcCUaHtiCaXA5qxHmoE/d5I6DMRl 4uFH5+NXMVynxLOgDrENcei39Qvdz6fUUTxDV3E+RCui/+sbhabIG8ZRzg7vSk4UMRdk kC+A/bRcvg/qs96dWAkBstukD7bHqU6A010kTJWfzONHs7YHu66+2/gju8qp516UD/Xt H/gdSb6Fd5FdMDdCd0/KZGuulTMVjsjHgrTVhO1McIxzzrce2TWp1Wc2VGBkt8lW7lcS s4rg== X-Forwarded-Encrypted: i=1; AJvYcCWrjdkN27oVTkKm4Mzb9+vn7WqQZx9aJAkd1/Wthvg1yw2VSPoYP+HSBCg2CLoSN7gSwvMd8E8AJ7aDdQw=@vger.kernel.org X-Gm-Message-State: AOJu0Yyu/styysCO6w13pveu1RozQVPfZFuYH2vKutzDntJrpFGtj26G TANsgiiLlWstEOrHG1ILwPfvm1rd20tjpNhbFuGDMDgThNr7ahkfor7C01kXFA70EI0= X-Gm-Gg: AY/fxX6R44GchwARDIf+76+CzjOrycykfR/kXkT1Q4CsMRSw5iS4h0RdEbCirhjVW+f 8+NQDsaYjHlrWFbQyxQWTe1gHWVkTiXbkZsyUHSWRX9UJ+OiS6sbdGu8XS0b2UY6QDbrtdOjfz8 GKcoG2jrGb3hLVlMCyVNaOXw1wGxWVfowXUguwnlx4wrD1w0OrmHikA04am6y4+OxHrGNfQDPlY zDbdi2Nji9Tf6DmWrBVmJlV5EERXXflNZkSbBMkdR/ot6UJd0GMgdre/8LXJZeUFcdVTl+/8GLg SJ4lNZxQXkNZZ2OOAQXR73mCybx7S/yheAmpKCF5fzQHlxLs74p6Sg5u3jYbnUlqZrgWU/RpUoQ AcF93Ww0iDBL/6ZbDhgUjfIk1KdiOg7Y4GcjCAItKJI1qeM2TKUeqBozNnCDhDL2GSelrp4v7Sg hIr3qcFt78z7ehzyGZw07wrkdwvMo54ywQPBhQ4BrkuKyIX+9s7A== X-Google-Smtp-Source: AGHT+IFdPW7SKSz+xwhuHpbyMMBAVJBVGlHfnH56plNqjISZJ9Pi0qmSI2oTZd0bCPzWi87zv+w2fQ== X-Received: by 2002:a05:600c:859c:b0:47d:25ac:3a94 with SMTP id 5b1f17b1804b1-47d25ac3acfmr69132505e9.17.1766439074242; Mon, 22 Dec 2025 13:31:14 -0800 (PST) Received: from ?IPv6:2a01:e0a:1d:5380:6cdc:9dff:7d8c:ff76? ([2a01:e0a:1d:5380:6cdc:9dff:7d8c:ff76]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47be27b28a7sm267228165e9.12.2025.12.22.13.31.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Dec 2025 13:31:14 -0800 (PST) Message-ID: <329d3e941ddcf7f594bcba23ffef18cd3c610293.camel@suse.com> Subject: Re: [PATCH v2 3/7] firmware: dmi: Read additional information when decoding DMI table From: Jean DELVARE To: "Mario Limonciello (AMD)" , Yazen Ghannam , x86@kernel.org Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H . Peter Anvin" , linux-kernel@vger.kernel.org Date: Mon, 22 Dec 2025 22:31:13 +0100 In-Reply-To: <20251216123354.9219-4-superm1@kernel.org> References: <20251216123354.9219-1-superm1@kernel.org> <20251216123354.9219-4-superm1@kernel.org> Organization: SUSE Linux Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.50.3 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Hi all, On Tue, 2025-12-16 at 06:33 -0600, Mario Limonciello (AMD) wrote: > Type 40 entries (Additional information) are summarized in section > 7.41 as part of the SMBIOS specification.=C2=A0 Save these entries when > decoding the DMI tables. >=20 > Signed-off-by: Mario Limonciello (AMD) > --- > v2: > =C2=A0* Drop some unneeded variables (LKP robot) > =C2=A0* Allow any length strings, not just 5 and longer > --- (...) Having read the whole series now, my conclusion is that we don't want to do that. The way AMD is storing this string in a type 40 record is absolutely not how these records are supposed to be used. So having generic code to store and retrieve strings from type 40 records is neither needed nor desirable. This is a hack from AMD, the best way to deal with it is with the minimum amount of code in the kernel and smallest memory footprint. Simply catch the string when you see it, log it, and be done with it. Thanks, --=20 Jean Delvare SUSE L3 Support