From: David Laight <David.Laight@ACULAB.COM>
To: 'Joe Perches' <joe@perches.com>, Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: RE: checkpatch
Date: Thu, 10 Dec 2020 09:34:37 +0000 [thread overview]
Message-ID: <32a8677e1bcf4d69ba019bfcefc9ea59@AcuMS.aculab.com> (raw)
In-Reply-To: <aea0efa93c17e431205eeb932a73efa7e21598a3.camel@perches.com>
From: Joe Perches
> Sent: 10 December 2020 05:26
>
> On Wed, 2020-12-09 at 19:13 +0100, Thomas Gleixner wrote:
> > Joe,
>
> Hi Thomas.
>
> > the below made it through my filters for some reason so I actually
> > looked and immediately wondered why checkpatch.pl did not identify this
> > as pure garbage.
> >
> > Original mail is here: lore.kernel.org/r/69cb540a-09d5-4956-b062-071ccded7090@web.de
> >
> > Can you have a look please? Adding brackets in the middle of the code
> > for absolutely no reason is wrong to begin with and then not indenting
> > the enclosed code makes it even worse.
>
> Well, maybe something like this, but there are probably some
> drawbacks with initializations.
Isn't the other likely problem where an extra code block
is being squeezed in after a case label without generating
a double-indent.
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
next prev parent reply other threads:[~2020-12-10 9:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87zh2mzw3h.fsf@nanos.tec.linutronix.de>
2020-12-10 5:25 ` checkpatch Joe Perches
2020-12-10 9:34 ` David Laight [this message]
2020-12-10 13:40 ` checkpatch Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32a8677e1bcf4d69ba019bfcefc9ea59@AcuMS.aculab.com \
--to=david.laight@aculab.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox