Re: [PATCH v2] selftests/resctrl: Fix noncont_cat_run_test for AMD

Reinette Chatre
2024-06-10T21:28:16Z

Hi Babu,

On 6/10/24 10:51 AM, Moger, Babu wrote:
> Hi
>
> On 6/10/24 11:20, Ilpo Järvinen wrote:
>> On Mon, 10 Jun 2024, Babu Moger wrote:
>>
>>> The selftest noncont_cat_run_test fails on AMD with the warnings. Reason
>>
>> noncont_cat_run_test()
>
> I want to mention the test here. not function. How about this?
>
> "The selftest non-contiguous CBM test fails on AMD with the warnings."
>

This does not take Ilpo's feedback regarding "the warnings" into account.
I agree with Ilpo (keeping his comment below) that "with the warnings"
sounds incomplete. Also, it is not necessary to mention both "selftest"
and "test" in "The selftest non-contiguous CBM test".

You can change it to something like:
The non-contiguous CBM test fails on AMD with:
/* insert error message here */

AMD always supports non-contiguous CBM but does not report
it via CPUID.

Fix the non-contiguous CBM test to use CPUID to discover
non-contiguous CBM support only on Intel.

>>
>> (In general, use () when refering to a function, same thing in the
>> shortlog).
>>
>> "the warnings" sounds like I should know about what warning it fails with
>> but there's no previous context which tells that information. I suggest
>> you either use "a warning" or quote the warning it fails with into the
>> commit message.
>>
>>> is, AMD supports non contiguous CBM masks but does not report it via CPUID.

The "M" in CBM is for "mask" so there is no need to write "mask" after CBM.

Reinette