From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AD3C1284B36 for ; Fri, 30 Jan 2026 18:17:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769797075; cv=none; b=RtrgHc6ifiv5ZkkkTB38Z6SlkKgPc/zPyTvsJJKWgZjg3URISwtlliiuISRviWGrRG5RfsRWuwIB1yeS4J0yp2ClBQ9er0SVX+oWyGG3ZxiXDdAGdZavX0NHegH/n23mLO+3sU54ejy5qZa4fckYPHmk+Mii6GLJij5xFOLl5t8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769797075; c=relaxed/simple; bh=AlsGI4n7E1eGCZF97Ycj9wTUYV/116rK/XKXyFkE0OU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=FqyfJqRLYnfSlGCTASvtZacE2sC7sgZS8/drb4JooX0ijAXboJq6gfA6x9EbcOIwwqU1KcwkJ3jH1pKA5L49eH46XJ14WRa068/7b3yTxP/Vp36P0an24HiSrbEE5KU4uW/6/Hv0Sz7pItw3+CPtfaRGvQiGcZk6obYnoKMeFvE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=aZNVwP0/; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=OGsE/NGK; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="aZNVwP0/"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="OGsE/NGK" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60UBuxv3555316 for ; Fri, 30 Jan 2026 18:17:52 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= yofwaTtZdItuKK8ONRAObKy8ywAmNqnO36FJ57xEjcE=; b=aZNVwP0/R5bSxwbD 25iUPXCEZVrdpd5BvqweujlgyyfQ3RHUhrRJlfK64QP4skHB9IoFN6mPM/m0NM3J WM31S+TTEqlzw09M3wcqbEOh62hyqTqIaZkg+NbfpVf6+nlVLQEXX+8Hv4VgF5oq d93zGu0EfQvPBZwlqfif2pV8gY9Bk2gEpMJtf5841J+yLLz2cuStgEuc8219xSwX wr75SGS6vBQWPv38qoBxuLYTDF1i1s7pIiTSslkQkV8xf/aIIzmP8Rp6zpg/WgTg DYpuXn42CYekJZ/DH4BHhZHpsjFn5pHo6+t0cqm2owUS8mHLKK9+fB3499c7cHKS 9+BXJA== Received: from mail-dl1-f71.google.com (mail-dl1-f71.google.com [74.125.82.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c0p59jcuy-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 30 Jan 2026 18:17:52 +0000 (GMT) Received: by mail-dl1-f71.google.com with SMTP id a92af1059eb24-124aa710af7so13698456c88.1 for ; Fri, 30 Jan 2026 10:17:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1769797071; x=1770401871; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=yofwaTtZdItuKK8ONRAObKy8ywAmNqnO36FJ57xEjcE=; b=OGsE/NGK7hlwqIhDfh8fz5aexSz7MET+VbwHAt08ycTrm1KhCIYaX2+x/JJQI/ZoLk neuBWIenl2f8OyQSAwbHSyKcL/Sez5/M6GwIWzc2OvseDvnowMfYIGlfJgk4B/y4VpeP T6NYzwg1yk5jpdvzXzAD9WMhELlVIFf1duSgy11gxMap1zJzzakjEIfkB28Poq8NItyB WtfUSrlQn2xlCr4CHztZpP9KB0e27svFVFakggUrrWQ8sGGfp16bBRG6OZ8FFdX1EmdD nwyKqpZKwc96GOr6WHIBBD/d7eBZyF0QYV/XHpT72JRI3z85aPme152QtF/Seb4ul6Jz ypug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769797071; x=1770401871; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=yofwaTtZdItuKK8ONRAObKy8ywAmNqnO36FJ57xEjcE=; b=sSh3c+BN59DLKOV54vZy+AGdqwNMBEeW7mcFxct5n410/3UTnnzKI6f223HxtjW+2B 0xHJNzuw+NhUQqxJSHwSGiCS7rGPkoASne/EHs5dc1g6L0rwBxNLFg9zcztC0dasmZRN OlBtU+qIZ3Am7m1xEtgUgkHZtGN0RQDeWz8jgD1D8D09psA8eDr5FDqzVAYD8o+xiNJg lX8XkUxRSiG92JQvzC/z8STGAKnVs5zR3QnujBxlnkwBa1+izRZmxi9bsdD8dZI9zAzf d+USoOgz7OiTUMV4nUhw2SIGflWXbPwgL7POU3cEVh+8cUttSkTJg9Hu+BVNu40s4zSW 8lvg== X-Forwarded-Encrypted: i=1; AJvYcCUikowo1sq/7GHBWlc42MWAMGGIOHTA+8c0U2qMotwXjrn/EiGrmlO2cvIk7u6wqTyc6ozorItOQ2Ibb5k=@vger.kernel.org X-Gm-Message-State: AOJu0Yz55CAaaEfefKT0u0WxHnKyZZr/+vDLMUUAnXCtHgG+vPGQ3/r/ tV+Rk9c7qtspsR3OpwcDjsGmSO0X+zHz6lVvS9pO4BEeMHH1Ae2mTwxMf8yCQVRw23qj9sOgmTW ihy3eqCQMg4sNBFx9COjRqSOqSEbAkps/TxOFWbhEECtn8Yprg3MOVPVaLQIZfzfsX2A= X-Gm-Gg: AZuq6aL2ok6+//uP64mM79AChq642jex1NuEm9J+nyjMFDuxXdseBF9MvSH+XN+WJXC OVgV3h0vf4ifggYBpFlE8U+QTEBuHRQlB6ICf5eiuWfK/Rr68RZ0pFdXk9lt4NccDoZYhrg61zd Vyj6vScXr5/EzJ32X9HmBu4kuFcD4123ohMIgfiAz7qUtGmRlCbmmr89EBXY3BeR9yT5VIdQ3d3 qaFbJwUnIMDejqLgpgxlE0FAowqwc8zK7Bx19/OlkBbbMIYiephrfAeR78XpCg1KrxWC75SbbkL CZjARHzkPjaALF87mksVVHhzCYU2fHDFy3LkhWdM8KQL6o5pzFQ18+3XQObR/adzAxVjVcHZXxw JI5IjHOjjsqy4GVkXATRsEEIC5izNeCLb/8M5OcF111bL96gpQslYF8irN8Ptvifg26sX6rm2jr 7x7g== X-Received: by 2002:a05:7022:6893:b0:124:acc6:6dd1 with SMTP id a92af1059eb24-125c100fdebmr2127526c88.46.1769797071325; Fri, 30 Jan 2026 10:17:51 -0800 (PST) X-Received: by 2002:a05:7022:6893:b0:124:acc6:6dd1 with SMTP id a92af1059eb24-125c100fdebmr2127510c88.46.1769797070680; Fri, 30 Jan 2026 10:17:50 -0800 (PST) Received: from ?IPV6:2603:8001:3300:be38:483f:f354:ec7a:3a61? ([2603:8001:3300:be38:483f:f354:ec7a:3a61]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-124a9d6b906sm12204320c88.4.2026.01.30.10.17.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 30 Jan 2026 10:17:50 -0800 (PST) Message-ID: <32fcfd27-9aa5-4466-80e2-e39a9670476b@oss.qualcomm.com> Date: Fri, 30 Jan 2026 10:17:51 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFT 2/3] arm64: dts: qcom: glymur: Add USB related nodes To: Abel Vesa Cc: Konrad Dybcio , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Greg Kroah-Hartman , Wesley Cheng , Pankaj Patil , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org References: <20260113-dts-qcom-glymur-add-usb-support-v1-0-98d6d387df01@oss.qualcomm.com> <20260113-dts-qcom-glymur-add-usb-support-v1-2-98d6d387df01@oss.qualcomm.com> <01de4054-eebf-4ef3-ad74-c806b208a848@oss.qualcomm.com> <6lieos5uudkgynizozrmzrj5ov57frzzl65b2fpanwbhbmehot@z5uhyv4ipyet> <4632ad3a-c893-449a-b0d1-48d9c93da7e9@oss.qualcomm.com> <86dade1c-3ac4-4352-8dc8-e7acaaf21321@oss.qualcomm.com> Content-Language: en-US From: Wesley Cheng In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: J78SnTX4PtSVM30jS0EmRZzs4fwPcB16 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTMwMDE0OSBTYWx0ZWRfX2YnMvFdwy8dX 8uuIjCEh+eJ/AY1CCnU/LP7r63W+hV6cy0t825gzFSoq80vgx1gT8Gbrj43ylCMhVxEoeGGma72 kO2dlHXOHattq37QzeZj2bcjVP2Oy9uU/spbVJXeKJqn+J4AcF5vfja0N3HXhq4mMkVo8pNfBu7 sO75JkZ3V8jEGEz1IwN+KBbJ8mseeX+GKzo4d15XfNUVnT4AXtEhRz2na9s1Ig5Iww9FUUIdAJ4 Qz9nfoPfJqse1fiY2U1nqc2XgokLosmRf37BOGIKsDNoOcRAjhNEu4MztppmRyPJ3JUW34tlvRA X89iD8pmKlPBOGE0+CaAnlGjMj/JNwpHdIiZ6WQ2EN0+TpSszVGdSdIHY1+e8YuHbvdY2y2LJfO jRayclIwjZjCheJkjK3jhkdvozw6+ebJqMwgH5+yCUsMn/hZBQAsZsIMbAOAwDrO6A5U3+jpVj5 tpQNk30wTkb09+/AW1A== X-Proofpoint-GUID: J78SnTX4PtSVM30jS0EmRZzs4fwPcB16 X-Authority-Analysis: v=2.4 cv=Re+dyltv c=1 sm=1 tr=0 ts=697cf5d0 cx=c_pps a=JYo30EpNSr/tUYqK9jHPoA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=ZdPEQgOY4kJE4xoCbToA:9 a=QEXdDO2ut3YA:10 a=Fk4IpSoW4aLDllm1B1p-:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-01-30_02,2026-01-30_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 malwarescore=0 suspectscore=0 clxscore=1015 bulkscore=0 adultscore=0 impostorscore=0 priorityscore=1501 lowpriorityscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601300149 On 1/28/2026 1:38 AM, Abel Vesa wrote: > On 26-01-27 14:26:47, Wesley Cheng wrote: >> >> >> On 1/27/2026 3:46 AM, Konrad Dybcio wrote: >>> On 1/27/26 12:41 PM, Abel Vesa wrote: >>>> On 26-01-13 14:13:32, Konrad Dybcio wrote: >>>>> On 1/13/26 1:33 PM, Abel Vesa wrote: >>>>>> From: Wesley Cheng >>>>>> >>>>>> The Glymur USB system contains 3 USB type C ports, 1 USB multiport >>>>>> controller and a USB 2.0 only controller. This encompasses 5 SS USB QMP >>>>>> PHYs (3 combo and 2 uni) and 6 M31 eUSB2 PHYs. All controllers are SNPS >>>>>> DWC3 based, so describe them as flattened DWC3 QCOM nodes. >>>>>> >>>>>> Signed-off-by: Wesley Cheng >>>>>> Co-developed-by: Abel Vesa >>>>>> Signed-off-by: Abel Vesa >>>>>> --- >>>>> >>>>> [...] >>>>> >>>>>> + snps,dis_u2_susphy_quirk; >>>>>> + snps,dis_enblslpm_quirk; >>>>>> + snps,dis_u3_susphy_quirk; >>>>>> + snps,usb2-lpm-disable; >>>>> >>>>> Other SoCs have a list that's much longer, please consult Wesley if >>>>> this list is enough >>>> >>>> Checked with Wesley. He confirmed that this trimmed list is fine. >>>> He said he dropped the rest since they are related to the power saving >>>> features like USB2/3 LPM (l1 or u1/u2) and we don't seem need those. >>> >>> Is that to say that those erratas were fixed in this hardware? >>> >>> Low-power states of the link are no less than desired is possible.. >>> >> >> I think it was misunderstood. We should keep the same quirks as our >> previous targets to enable USB LPM support in certain cases. >> >> snps,hird-threshold = /bits/ 8 <0x0>; >> snps,usb2-gadget-lpm-disable; >> snps,dis-u1-entry-quirk; >> snps,dis-u2-entry-quirk; >> snps,is-utmi-l1-suspend; >> snps,usb3_lpm_capable; >> snps,has-lpm-erratum; >> tx-fifo-resize; >> snps,dis_u2_susphy_quirk; >> snps,dis_enblslpm_quirk; >> snps,usb2-lpm-disable; >> >> There are some questionable ones that I'm on the fence though, which we >> should consider removing: >> snps,usb2-lpm-disable >> snps,usb2-gadget-lpm-disable >> >> USB L1 support is routinely being verified on our devices (in host and >> device modes), so if its power over performance, we should consider removing >> the properties to disable USB L1. (esp since we're defining the HIRD >> threshold as well...) > > This should've been sorted out months ago! As part of the initial bring-up or > even the initial submission here: > https://lore.kernel.org/all/20250925-v3_glymur_introduction-v1-23-24b601bbecc0@oss.qualcomm.com/ > > Anyway, is the following list the one we should use then? > > snps,hird-threshold = /bits/ 8 <0x0>; > snps,dis-u1-entry-quirk; > snps,dis-u2-entry-quirk; > snps,is-utmi-l1-suspend; > snps,usb3_lpm_capable; > snps,has-lpm-erratum; > tx-fifo-resize; > snps,dis_u2_susphy_quirk; > snps,dis_enblslpm_quirk; > This list looks good. Thanks Wesley Cheng