From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Linux PM <linux-pm@vger.kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Lukasz Luba <lukasz.luba@arm.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
Zhang Rui <rui.zhang@intel.com>
Subject: [PATCH v1 1/6] thermal: sysfs: Trigger zone temperature updates on sysfs reads
Date: Fri, 10 May 2024 16:13:31 +0200 [thread overview]
Message-ID: <3304112.44csPzL39Z@kreacher> (raw)
In-Reply-To: <13518388.uLZWGnKmhe@kreacher>
From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Reading the zone temperature via sysfs causes the driver callback to
be invoked, but it does not cause the thermal zone object to be updated.
This is problematic if the zone temperature read via sysfs differs from
the temperature value stored in the thermal zone object as it may cause
the kernel and user space to act against each other in some cases.
For this reason, make temp_show() trigger a zone temperature update if
the temperature returned by thermal_zone_get_temp() is different from
the temperature value stored in the thermal zone object.
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---
drivers/thermal/thermal_core.c | 2 +-
drivers/thermal/thermal_sysfs.c | 3 +++
2 files changed, 4 insertions(+), 1 deletion(-)
Index: linux-pm/drivers/thermal/thermal_sysfs.c
===================================================================
--- linux-pm.orig/drivers/thermal/thermal_sysfs.c
+++ linux-pm/drivers/thermal/thermal_sysfs.c
@@ -42,6 +42,9 @@ temp_show(struct device *dev, struct dev
if (ret)
return ret;
+ if (temperature != READ_ONCE(tz->temperature))
+ thermal_zone_device_update(tz, THERMAL_EVENT_TEMP_SAMPLE);
+
return sprintf(buf, "%d\n", temperature);
}
Index: linux-pm/drivers/thermal/thermal_core.c
===================================================================
--- linux-pm.orig/drivers/thermal/thermal_core.c
+++ linux-pm/drivers/thermal/thermal_core.c
@@ -429,7 +429,7 @@ static void update_temperature(struct th
}
tz->last_temperature = tz->temperature;
- tz->temperature = temp;
+ WRITE_ONCE(tz->temperature, temp);
trace_thermal_temperature(tz);
next prev parent reply other threads:[~2024-05-10 14:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-10 14:11 [PATCH v1 0/6] thermal: core: Assorted improvements for v6.11 Rafael J. Wysocki
2024-05-10 14:13 ` Rafael J. Wysocki [this message]
2024-05-13 7:11 ` [PATCH v1 1/6] thermal: sysfs: Trigger zone temperature updates on sysfs reads Lukasz Luba
2024-05-16 9:04 ` Rafael J. Wysocki
2024-05-16 9:45 ` Daniel Lezcano
2024-05-16 10:02 ` Rafael J. Wysocki
2024-05-16 12:56 ` Rafael J. Wysocki
2024-05-10 14:14 ` [PATCH v1 2/6] thermal: trip: Rename __thermal_zone_set_trips() to thermal_zone_set_trips() Rafael J. Wysocki
2024-05-10 14:16 ` [PATCH v1 3/6] thermal: trip: Make thermal_zone_set_trips() use trip thresholds Rafael J. Wysocki
2024-05-10 14:18 ` [PATCH v1 4/6] thermal: trip: Use READ_ONCE() for lockless access to trip properties Rafael J. Wysocki
2024-05-10 14:19 ` [PATCH v1 5/6] thermal: gov_bang_bang: Drop unnecessary cooling device target state checks Rafael J. Wysocki
2024-05-10 14:20 ` [PATCH v1 6/6] thermal: core: Avoid calling .trip_crossed() for critical and hot trips Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3304112.44csPzL39Z@kreacher \
--to=rjw@rjwysocki.net \
--cc=daniel.lezcano@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=rafael@kernel.org \
--cc=rui.zhang@intel.com \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox