From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755523AbbG1M1r (ORCPT <rfc822;w@1wt.eu>);
	Tue, 28 Jul 2015 08:27:47 -0400
Received: from mail-yk0-f179.google.com ([209.85.160.179]:35937 "EHLO
	mail-yk0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752435AbbG1M1q (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 28 Jul 2015 08:27:46 -0400
From: Joshua Clayton <stillcompiling@gmail.com>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
        Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Nitin Kuppelur <nitinkuppelur@gmail.com>,
        Vaishali Thakkar <vthakkar1994@gmail.com>,
        Tapasweni Pathak <tapaswenipathak@gmail.com>,
        Daniel Baluta <daniel.baluta@intel.com>,
        Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
        Max Perepelitsyn <mperepelitsyn@gmail.com>,
        Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
        Cristina Opriceana <cristina.opriceana@gmail.com>,
        Dogukan Ergun <dogukan.ergun@gmail.com>,
        Julia Lawall <Julia.Lawall@lip6.fr>,
        Dan Carpenter <dan.carpenter@oracle.com>,
        Haneen Mohammed <hamohammed.sa@gmail.com>,
        Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>,
        devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V3 1/8] staging: rtl8712: fix buggy size calculation
Date: Tue, 28 Jul 2015 05:27:41 -0700
Message-ID: <3309030.zsCfj96v3x@diplodocus>
User-Agent: KMail/4.14.10 (Linux/4.2.0-rc3-next-20150722-00005-gf1d4451; KDE/4.14.10; x86_64; ; )
In-Reply-To: <20150728114656.GF15027@sudip-pc>
References: <cover.1438057939.git.stillcompiling@gmail.com> <305999598d7738feabdc8e5df5400b3e7be7f5ed.1438057939.git.stillcompiling@gmail.com> <20150728114656.GF15027@sudip-pc>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tuesday, July 28, 2015 05:16:56 PM Sudip Mukherjee wrote:
> On Mon, Jul 27, 2015 at 09:41:10PM -0700, Joshua Clayton wrote:
> > r8712_get_ndis_wlan_bssid_ex_sz has a "6 * sizeof(unsigned long)"
> > where the underlying struct has a 6 * unsigned char.
> > Simplify the calculation by just subtracting the variable part from
> > the size of the struct.
> > 
> > This also gets rid of a use of typedef NDIS_802_11_RATES_EX
> > 
> > Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
> > ---
> <snip>
> >  
> >  u8 *r8712_get_capability_from_ie(u8 *ie)
> 
> Something is wrong. The same patch is getting repeated in the same mail
> multiple times. I deleted almost 2500 lines after this before sending
> this reply. See how your patch is looking like:
> http://www.gossamer-threads.com/lists/linux/kernel/2224869
> 
> regards
> sudip
> 
Oh No!
I made a tweak to git-send-email to try to get past the problem with perl 5.22
That was causing git-send-email to crash.
The whole series, including the cover letter is like this.
I will resubmit when I have fixed this problem.