From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752877AbdJLQak (ORCPT <rfc822;w@1wt.eu>);
        Thu, 12 Oct 2017 12:30:40 -0400
Received: from mailout3.samsung.com ([203.254.224.33]:21786 "EHLO
        mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751040AbdJLQah (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 12 Oct 2017 12:30:37 -0400
X-AuditID: b6c32a37-c75ff70000001076-29-59df98aa4631
From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
To: Colin Ian King <colin.king@canonical.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
        linux-fbdev@vger.kernel.org, kernel-janitors@vger.kernel.org,
        linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] video: fbdev: radeon: make const array post_divs
 static, reduces object code size
Date: Thu, 12 Oct 2017 18:30:32 +0200
Message-id: <3309966.vVeY8tZnvB@amdc3058>
User-Agent: KMail/4.13.3 (Linux/3.13.0-96-generic; KDE/4.13.3; x86_64; ; )
In-reply-to: <268158e3-00d6-b9c3-34a4-e8ce8e464276@canonical.com>
MIME-version: 1.0
Content-transfer-encoding: 7Bit
Content-type: text/plain; charset="us-ascii"
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrAIsWRmVeSWpSXmKPExsWy7bCmvu6qGfcjDU6u17b40NTKbPF7dS+b
        xZWv79kstt6StjjR94HV4vKuOWwObB6zGnrZPHretLB63O8+zuTxeZNcAEsUl01Kak5mWWqR
        vl0CV8bhTbeZCk5wVJydc4ClgXENWxcjJ4eEgInEhoeT2UFsIYEdjBJzX6V2MXIB2d8ZJZat
        XsEKUzRx9yQmiMQGRokVr14xQzhfGSUevFkLVsUmYCUxsX0VI4gtIqArsbb7J1gHs8A2Ronn
        O7qAdnBwCAtkSBxcoQBSwyKgKnF23RuwM3gFNCXuTN8OZosKeEls2dfOBGJzCjhKfHu/mhmi
        RlDix+R7LCA2s4C8xL79U1khbB2Js8fWMYLskhBYwybxeeoSFoizXSR+79jODGELS7w6vgXs
        BgkBaYlLR20hwtMZJbb/loDo3cwosWr3BHaIhLXE4eMXoRbwSbz72sMK0csr0dEmBFHiIfHl
        xHMmCNtR4tOK3SyQQNnCKLHn8if2CYyys5DcPQvJ3bOQ3L2AkXkVo1hqQXFuemqxYYGxXnFi
        bnFpXrpecn7uJkZwOtAy38G44ZzPIUYBDkYlHl6BqvuRQqyJZcWVuYcYJTiYlUR4PTqBQrwp
        iZVVqUX58UWlOanFhxilOViUxHnF1l+LEBJITyxJzU5NLUgtgskycXBKNTD2ltrOO7jnxsHz
        D3lLJn5Ie1Xwacmc2qUKliuvcKdbO6wOnHik5uMeof074pf52Nm6zGNP/2jl9z7iU1ip2Szv
        wBVyupPUPbRmLc1WZJxwf6d18nu1n+vaJtSabLz981ekd2HrkZ9/mUqmvW7ymm4nH/B3z/QX
        7p3H/ihxFjN5Pk2ad/dB5MJTSizFGYmGWsxFxYkAoCwBJAMDAAA=
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrNLMWRmVeSWpSXmKPExsVy+t9jQd1VM+5HGuz5q2DxoamV2eL36l42
        iytf37NZbL0lbXGi7wOrxeVdc9gc2DxmNfSyefS8aWH1uN99nMnj8ya5AJYoLpuU1JzMstQi
        fbsErozDm24zFZzgqDg75wBLA+Mati5GTg4JAROJibsnMXUxcnEICaxjlDi7+x+U85VRonXa
        ERaQKjYBK4mJ7asYQWwRAV2Jtd0/wYqYBbYxSnx4dQ1slLBAhsSfzafAilgEVCXOrnsDFucV
        0JS4M307mC0q4CWxZV87E4jNKeAo8e39amaIbUCDLn35yQrRICjxY/I9sM3MAvIS+/ZPZYWw
        tSTW7zzONIGRfxaSsllIymYhKVvAyLyKUTK1oDg3PbfYqMAwL7Vcrzgxt7g0L10vOT93EyMw
        iLcd1urbwXh/SfwhRgEORiUeXoGq+5FCrIllxZW5hxglOJiVRHg9OoFCvCmJlVWpRfnxRaU5
        qcWHGKU5WJTEeW/nHYsUEkhPLEnNTk0tSC2CyTJxcEo1ME4LsAhROLp93anMA5NrXy7OcBc/
        U3V92e2utf+mqKeZyaqHb9BZohflW6jtdyJE/rvGFNekL7xfCrbdnN38KmI3f76KXujywpu3
        Sj/c/ea5uuBW/T/RP9qFHDk3Lk4rvrbpW/TVGSs3fP6+/0Rq3TpDS/XYBwbe0Xl3mgr+3+t7
        Zj3vUBWzSrwSS3FGoqEWc1FxIgDtVeJNXgIAAA==
X-CMS-MailID: 20171012163034epcas1p46681b73c1c2f48bd981e3ac026c80dba
X-Msg-Generator: CA
X-Sender-IP: 182.195.42.142
X-Local-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?=
        =?UTF-8?B?ZWwgKFRQKRvsgrzshLHsoITsnpAbU2VuaW9yIFNvZnR3YXJlIEVuZ2luZWVy?=
X-Global-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?=
        =?UTF-8?B?ZWwgKFRQKRtTYW1zdW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBF?=
        =?UTF-8?B?bmdpbmVlcg==?=
X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?=
CMS-TYPE: 101P
X-CMS-RootMailID: 20170919213206epcas2p3a2bea87468fa266cf1c94829444ab162
X-RootMTR: 20170919213206epcas2p3a2bea87468fa266cf1c94829444ab162
References: <CGME20170919213206epcas2p3a2bea87468fa266cf1c94829444ab162@epcas2p3.samsung.com>
        <3245965.OqUEzHD6FT@amdc3058>
        <268158e3-00d6-b9c3-34a4-e8ce8e464276@canonical.com>
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thursday, October 12, 2017 05:17:49 PM Colin Ian King wrote:
> On 12/10/17 17:17, Bartlomiej Zolnierkiewicz wrote:
> > 
> > [ added dri-devel ML to cc: ]
> > 
> > On Tuesday, September 19, 2017 10:32:01 PM Colin King wrote:
> >> From: Colin Ian King <colin.king@canonical.com>
> >>
> >> Don't populate the read-only const array post_divs on the stack,
> >> nstead make it static. Makes the object code smaller by 90 bytes:
> >>
> >> Before:
> >>    text	   data	    bss	    dec	    hex	filename
> >>   40231	   8584	    896	  49711	   c22f	radeon_base.o
> >>
> >> After:
> >>    text	   data	    bss	    dec	    hex	filename
> >>   39914	   8744	    960	  49618	   c1d2	radeon_base.o
> >>
> >> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> > 
> > Are these results obtained using the same compiler as the other patches
> > (gcc version 7.2.0, x86_64)?
> 
> Yes, I forgot to annotate it.

Patch queued for 4.15 (with updated patch description), thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics