Re: [PATCH] perf probe: Delete an unnecessary check before the function call "strfilter__delete"

Masami Hiramatsu
2015-07-06T11:41:40Z

On 2015/07/04 14:54, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sat, 4 Jul 2015 07:44:22 +0200
>
> The strfilter__delete() function tests whether its argument is NULL and
> then returns immediately. Thus the test around the call is not needed.
>
> This issue was detected by using the Coccinelle software.
>

This looks OK for me.

Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>

> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
> tools/perf/builtin-probe.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/tools/perf/builtin-probe.c b/tools/perf/builtin-probe.c
> index 1272559..b81cec3 100644
> --- a/tools/perf/builtin-probe.c
> +++ b/tools/perf/builtin-probe.c
> @@ -297,8 +297,7 @@ static void cleanup_params(void)
> clear_perf_probe_event(params.events + i);
> line_range__clear(&params.line_range);
> free(params.target);
> - if (params.filter)
> - strfilter__delete(params.filter);
> + strfilter__delete(params.filter);
> memset(&params, 0, sizeof(params));
> }
>
>

--
Masami HIRAMATSU
Linux Technology Research Center, System Productivity Research Dept.
Center for Technology Innovation - Systems Engineering
Hitachi, Ltd., Research & Development Group
E-mail: masami.hiramatsu.pt@hitachi.com