Re: [PATCH 1/1] fs-jbd: Deletion of an unnecessary check before the function call "iput"

Jan Kara
2014-11-18T09:16:08Z

On Sun 16-11-14 23:40:18, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sun, 16 Nov 2014 23:23:19 +0100
>
> The iput() function tests whether its argument is NULL and then
> returns immediately. Thus the test around the call is not needed.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
> fs/jbd/journal.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Thanks. Merged into my tree.

Honza

>
> diff --git a/fs/jbd/journal.c b/fs/jbd/journal.c
> index 06fe11e..32fe03e 100644
> --- a/fs/jbd/journal.c
> +++ b/fs/jbd/journal.c
> @@ -1373,8 +1373,7 @@ int journal_destroy(journal_t *journal)
> }
> mutex_unlock(&journal->j_checkpoint_mutex);
>
> - if (journal->j_inode)
> - iput(journal->j_inode);
> + iput(journal->j_inode);
> if (journal->j_revoke)
> journal_destroy_revoke(journal);
> kfree(journal->j_wbuf);
> --
> 2.1.3
>
>
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR