Re: [PATCH] au1100fb: Delete unnecessary checks before two function calls

Dan Carpenter
2015-02-05T17:21:50Z

On Thu, Feb 05, 2015 at 03:20:27PM +0100, SF Markus Elfring wrote:
> >> The functions clk_enable() and clk_disable() test whether their argument
> >> is NULL and then return immediately.
> >
> > This isn't true for clk_enable().
>
> I stumble on an interesting name space issue once more.
>

The "once more" is the problem in this statement. Other people would
have stopped making the mistake by now. I am able to see your bugs so
you should be able to see your bugs as well.

>
> > It's frustrating that you make the same mistake over and over
> > and you are fine with doing that.
>
> I admit that there can be also risks with my update suggestions
> in similar ways to contributions from other software developers.
>

At times, I have told other people to stop sending cleanups until they
can at least fix a bugs to balance out the bugs they have introduced.
It's unacceptable to only introduce bugs and never fix any.

regards,
dan carpenter