Re: [PATCH 2/4] SCSI-QLA4...: Less function calls in qla4xxx_is_session_exists() after error detection

SF Markus Elfring
2015-02-07T17:23:51Z

> 1) People gloss over initializers without reading them.

I would find such a habit strange.

> You shouldn't put complicated code in initializers.

Does the affected memory allocation fall into such a category?

> 2) It means you have to put a line of separation between the allocation
> and the NULL check, but they should be next to each other.

Would you like to extend the Linux coding style documentation?

Regards,
Markus