From: Hanna Linder <hannal@us.ibm.com>
To: Davide Libenzi <davidel@xmailserver.org>
Cc: Hanna Linder <hannal@us.ibm.com>,
Manfred Spraul <manfred@colorfullife.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] use correct wakeups in fs/pipe.c
Date: Sun, 20 Oct 2002 04:45:56 -0700 [thread overview]
Message-ID: <33170000.1035114356@w-hlinder> (raw)
In-Reply-To: <Pine.LNX.4.44.0210201646160.989-100000@blue1.dev.mcafeelabs.com>
--On Sunday, October 20, 2002 16:49:24 -0700 Davide Libenzi <davidel@xmailserver.org> wrote:
> On Sun, 20 Oct 2002, Hanna Linder wrote:
>
>> --On Saturday, October 19, 2002 20:12:42 +0200 Manfred Spraul <manfred@colorfullife.com> wrote:
>>
>> > wake_up_interruptible() and _sync() calls are reversed in pipe_read().
>> >
>> > The attached patches only calls _sync if a schedule() call follows.
>> >
>>
>> FYI. This patch fixes a hang on pipetest.c with the --epoll option.
>
> Hanna, I'm not sure if your port of the epoll pipe code on 2.5.44 is
> correct. That fix shouldn't affect epoll. Try the code I sent you
> yesterday or today, it working fine on my machine without the fix.
You are right. I had changed pipetest.c in all my debugging earlier
and used the original version of pipetest.c with your new patch and
Manfreds, which worked. I will be more carefull in the future.
Thanks.
Hanna
prev parent reply other threads:[~2002-10-20 23:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-19 18:12 [PATCH] use correct wakeups in fs/pipe.c Manfred Spraul
2002-10-20 11:28 ` Hanna Linder
2002-10-20 23:49 ` Davide Libenzi
2002-10-20 11:45 ` Hanna Linder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33170000.1035114356@w-hlinder \
--to=hannal@us.ibm.com \
--cc=davidel@xmailserver.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manfred@colorfullife.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox