From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C3D330595B for ; Thu, 7 May 2026 08:03:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778141008; cv=none; b=FLNL2TGIt7UjKkAUDFXUCeK9VpM/Vv8mWtCpe80wa3sG7cJCDX40L7ltJ24GhII3pAPASAGEGxz5C4tOYgReJY3Wj7dZrVcHGpilkpyujvTY42uNPRtEUPjnakE3fZYil9A+U8byYgQIus5jM1eOq0U6hiPtKidhSynsdoYkjuE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778141008; c=relaxed/simple; bh=JKeHjw5d+vS95B0gqhrrMQ08nSofzwyMUDvN6S3xMYs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=AiWBZ/OgTidpFAeJx/2OBrH5iYscQxWSyr23zR+IZPQ2omwmd1Ix7ASN/vjlc0ST+fJEqZF7IgGLg3glTL+IqxbtZXjG8VuFJVH3BCuBvUBflTZJ4K2oIZQqrALkaSTmnpv4jhWxwWcDO2PGkTYNFgnAdR0SGsSVx2WUQfk1Rlw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=MYuwx82w; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=r2vwpdfE; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="MYuwx82w"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="r2vwpdfE" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778141006; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=j0bzjHNwg/4dsgcGNIVawkmXretC17GVDXq9ice+Mi4=; b=MYuwx82wWgsiwjIFdFBmcwGAKjz9d4LhA4Jf8fdqB58pR3XTQNw9XjAt2lnMJCxIsUQJJH FpbqZHGtq+D/XD+9OjazqxJXDvwkgHgkzg0BMcLzhcW4/PgpjCAvenjA3sThwKE2HITOep DBWBnY0tNsWOrxgoc+ALxdhtB0vOZJw= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-389-HZkIynphMyiPkQHjEsT6pA-1; Thu, 07 May 2026 04:03:24 -0400 X-MC-Unique: HZkIynphMyiPkQHjEsT6pA-1 X-Mimecast-MFC-AGG-ID: HZkIynphMyiPkQHjEsT6pA_1778141004 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-43d789cebcfso1208881f8f.1 for ; Thu, 07 May 2026 01:03:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1778141003; x=1778745803; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=j0bzjHNwg/4dsgcGNIVawkmXretC17GVDXq9ice+Mi4=; b=r2vwpdfEeAvIFv+y21W3BBDIi/4dHWulKm6y/SiQNxL+qJB/GoHgnXP+RxBBRVRvz0 P0VCEKnzRC8MXCaWyrUhxssm4w9KeDPxaidhbAHyJLTAXwrYoROX5ssh24xBGRJaC7Ij srXmPnX3SX8El5KAzQ5f75kwhuw3Ti4MUfGtsBokzOh5znkbCLykVme8HAEHVR3I3C8U KuePY5f6uymBndKO0FlveKCP82gIo8KqiGNATrhgVMxZhsh7cN+gerq7iVHer28st9R6 m6Qygjo24+HvhyGLUsbmtOydJ9Lx30+wMsBgm4mFvnLx2/R0iobHJ1aeQy4QFPELsQ7Y dP3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778141003; x=1778745803; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=j0bzjHNwg/4dsgcGNIVawkmXretC17GVDXq9ice+Mi4=; b=O9bDcr2ifBbmg5w5sKAqAlmrIk/0TZnVyZRWZaBh9omFFzCuG08SqlPnaSvTpdF/JX UKEkj/eNKA9Ev/59pkNFp01gc2JoTmw4PSHqYyH944Hkwejji1jPivjb7hn6/336Psu8 xwfbviy6htj1E/lxY5YRuEzA1320sil5W7jBZnkKwSt88ib+qeFRfDbJWGVBxR4vAv2U I1bw16gWYeEMPcqAFOQtj+XZGs75OUyCrROtPm3c6TiIsfwAq5Y/7hlfuKZifinSBmbb +T7AXABQ4AOP361QpEJ8mpyS7MFbWviBPd6OQPwpMINrqw0uMuwthBMWG24he/Y0RgFs Krlw== X-Forwarded-Encrypted: i=1; AFNElJ9NKqAvVmqSLze4bfcKn+dz6jhNq868BbTa480zG+rr3cphtqA9TnpqMPWBpgrXWpTKmg5SC18QxAt2z04=@vger.kernel.org X-Gm-Message-State: AOJu0YxwoyFPtJamIUHvOVyvTBOPozr/ub50HylJ0qeqWIP0bgRCN+Mm aFDNnGeZiEHwqlo03+fWF7JKVyiiQPJnOgd+omrXGzWFIITuTX/Mb7twW2rnhRzrGY/K4b7bkhQ X8wxa4LtQZXXAmVgggGp0AgoVpjcQ3CjqS03VCTRYCUgMfkBE1fG4ZZ3wNkFN+Y/fKg== X-Gm-Gg: AeBDievFYRYWe1zgBDIMRJD83OQMfzZKlpbdx6+fz+lPgdwXs9tQ3mERHwSXoQsH4Xm ds25YehCdfuT4bS/z2M+IPMtFd0zXDNesOCFH55mZWRBbcGXCc0skiMaosxkyu6LvLALAVBWjff QCeRLMaDQydOvWxlhij3mtGDdx2pFxiRSCRCYzwrfZ6au5HHYcz68UDLYPG5g8EJlPviuSHj0RM 4QWOqIgR6hcJ0mF+w+K/MILaBHAGgwwudwLS19LgFgJSgtuRPr+EHLfhiSozAV09wF/ns/lI5md MCkKTqQ9vE1IAiiOm5snnV4Pm6wLTwmm3Zfj/xxIS82bP5N4rG/lIzkCvT8PFZEVZVFVhVmpqFA U5VQ7PJRgfu7usNLkGSnHfgFD8ctewk3sNoXaeBcyi1ob2yZgAAJ0281IFGLXfkBPnw== X-Received: by 2002:adf:e905:0:b0:43d:210:2b2d with SMTP id ffacd0b85a97d-452eaa28388mr2016732f8f.31.1778141003660; Thu, 07 May 2026 01:03:23 -0700 (PDT) X-Received: by 2002:adf:e905:0:b0:43d:210:2b2d with SMTP id ffacd0b85a97d-452eaa28388mr2016696f8f.31.1778141003233; Thu, 07 May 2026 01:03:23 -0700 (PDT) Received: from [192.168.88.32] ([150.228.93.82]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45055960973sm18449092f8f.30.2026.05.07.01.03.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 May 2026 01:03:22 -0700 (PDT) Message-ID: <3317a78d-de64-4df5-b132-454b4e00a42a@redhat.com> Date: Thu, 7 May 2026 10:03:21 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v6 04/10] enic: add admin CQ service with MSI-X interrupt and NAPI polling To: Satish Kharat , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Sesidhar Baddela References: <20260503-enic-sriov-v2-admin-channel-v2-v6-0-0af4fbc2d86d@cisco.com> <20260503-enic-sriov-v2-admin-channel-v2-v6-4-0af4fbc2d86d@cisco.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: <20260503-enic-sriov-v2-admin-channel-v2-v6-4-0af4fbc2d86d@cisco.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 5/3/26 1:22 PM, Satish Kharat wrote: > +static void enic_admin_msg_enqueue(struct enic *enic, void *buf, > + unsigned int len) > +{ > + struct enic_admin_msg *msg; > + > + msg = kmalloc(struct_size(msg, data, len), GFP_ATOMIC); > + if (!msg) { > + enic->admin_msg_drop_cnt++; > + if (net_ratelimit()) > + netdev_warn(enic->netdev, > + "admin msg enqueue drop (len=%u drops=%llu)\n", > + len, enic->admin_msg_drop_cnt); Failed allocation will splat dmesg; no need to added additional error messages (here and elsewhere in the series). /P