From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F3C71DED40 for ; Fri, 17 Jan 2025 23:24:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=192.198.163.7 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737156275; cv=fail; b=MbKl6Cv3tO2IzT+2hKnzJ2ATRW1NJxR8IvwxM2omjDWErX6iXqH3Hxqf6GB/ceuDYCtI5HrvzSLAvpMX8DmURS1oc5PVTstixjpcL6WlmKQGveyMDu9DqJLX+ldbMLz+mF+2Qk+lVv9xxaDgi48Y2t6kJX2gjkkMBA2RaDlL5UU= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737156275; c=relaxed/simple; bh=tD51hZZVxrJS4aIXDJyBUF7h0iqnRqkzb9rV+jLG5dc=; h=Message-ID:Date:Subject:To:CC:References:From:In-Reply-To: Content-Type:MIME-Version; b=oiXtHJuSw3Co3Y9rWn3LtXhQLS0rIjDlJNJGdK7iRP+tf3UoaS3DSD9vYIIVXRdL/Tna815BslHO/TFBCLXjq2aDR9Bju14H1sDgLkNAG+MUKYCN4fI3jXWj0H0sQGnIdAn4GpbcWkRQAjswfsiVFAVjDRN7XzOzYV11r6ygjsM= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=fFr8YjF8; arc=fail smtp.client-ip=192.198.163.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="fFr8YjF8" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1737156273; x=1768692273; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=tD51hZZVxrJS4aIXDJyBUF7h0iqnRqkzb9rV+jLG5dc=; b=fFr8YjF85PP3wQuw0InK4n89osXcRe6te0YMFScknp3j/37SSwY4iyAG LOd1QrQAjc0TjFoFCKQdOZNPi8CAGx5qEaIoS6o+2tOwtZ4tEmB3dToD+ BCb+cXOmcCaw3WWJiqsHEX+zuvvjuxTyJsMalDH8dWezzvLJpZSQSQm9S o4bYS/LEPn+KViCP4uxdYIyMATrH0ry/1Vd23xPdNyM1UZo/lco0xpq8v BWqSY6l/hnAVX+JwljRvnSkIl/l49MR3+kd6hFlZirpuQeSC8x5bER0A7 JezASacI15zsNH5DMSxqL6ZvyUEeohGV0gNI19+iIfQG5AkMI4sHUtw3/ Q==; X-CSE-ConnectionGUID: GHIlb3PgQ3+bYbqcGc6g0A== X-CSE-MsgGUID: rZzhvv29QjW1Iu9Y/htEbA== X-IronPort-AV: E=McAfee;i="6700,10204,11318"; a="62976096" X-IronPort-AV: E=Sophos;i="6.13,213,1732608000"; d="scan'208";a="62976096" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jan 2025 15:24:33 -0800 X-CSE-ConnectionGUID: 6yz2lxBNT7KNytDP5Tg2Ug== X-CSE-MsgGUID: ZkcvTxQUQLy4WxNNkWF4MQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.13,213,1732608000"; d="scan'208";a="110934147" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orviesa004.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 17 Jan 2025 15:24:33 -0800 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.44; Fri, 17 Jan 2025 15:24:31 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.44 via Frontend Transport; Fri, 17 Jan 2025 15:24:31 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.177) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.44; Fri, 17 Jan 2025 15:24:31 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=mERSfSACkCauK3alZKxWoiQuYJIX+cODTbqcpBzvaSVFoBh5Rvz9WboF7k+tglgRq4JlTrEDw2JZvPBCSyCuwS8rRTnZqKGolDjBFjv5tJfPjZJPyMQ8slyS8uPLmtZrVA1WtFlBGB/wE4Bpr/4R0yuEeaMTc+HK9IGDMzxAKkoeG1Lpk315k6IpklSpLpl8VdLTjqPq7AY3kGsOSuGtxKkLPQV9j2I/IJn3berbDrNZJY3/0CtrUff/w/ft5nGu1TGKCOeaXly8jWivIqqNT8iaeZnU8y434n7bEQ0EP9jHH9RLRwxW6emFUOJgj4L9TjWjke4FpaWNPoZw6//WZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jdOFOiBWkvXJmLdZO5opMhew5Q0DJ0qmRhyD95zHEbg=; b=KecLWARFD9ypB0JpmllrJXv+8WZ2qk8M9LV5zBBXLfJRjlhoBSKJfbsTuK01uszDHapLbCQKoUcdIaIjDO6ppn8/J71TgAGfdPeoF0YmpnnBNKIXKhoEzVhiFg+YHejghlBo88Zsdifzr5dL93imS6ba8XWc73BuYXg1/c4kFH3oSZNg+APfNBaA+/pUMIA7cQcz1oJJeQXjHyluwL+BAu1Id14qQzIcsY0gFUDPZ3zROBbS34uLxuQDv6tMwLLLPhQmWoD2F6IRL88KzKdNApqLzw3ZNUyeywnv6TjEAXhdZFpnwzEcQRAkaGpKz5M7FKsF+eh+xar5+o2aQ9yBGQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7925.namprd11.prod.outlook.com (2603:10b6:8:f8::18) by CY5PR11MB6234.namprd11.prod.outlook.com (2603:10b6:930:25::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8356.13; Fri, 17 Jan 2025 23:24:28 +0000 Received: from DS0PR11MB7925.namprd11.prod.outlook.com ([fe80::b1ef:c95b:554d:19c9]) by DS0PR11MB7925.namprd11.prod.outlook.com ([fe80::b1ef:c95b:554d:19c9%4]) with mapi id 15.20.8356.014; Fri, 17 Jan 2025 23:24:27 +0000 Message-ID: <331a04dc-60df-47ad-8ba6-53a605d9f472@intel.com> Date: Fri, 17 Jan 2025 15:24:25 -0800 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] x86/fpu: Fix the os panic issue caused by the XGETBV instruction To: Sean Christopherson CC: Tony W Wang-oc , , , , , , , , , , , , , , , Lyle Li References: <20250102075419.2559-1-TonyWWang-oc@zhaoxin.com> Content-Language: en-US From: "Chang S. Bae" In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: BYAPR07CA0066.namprd07.prod.outlook.com (2603:10b6:a03:60::43) To DS0PR11MB7925.namprd11.prod.outlook.com (2603:10b6:8:f8::18) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7925:EE_|CY5PR11MB6234:EE_ X-MS-Office365-Filtering-Correlation-Id: b24e1020-badd-41cd-8d4a-08dd374e163c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|1800799024|366016; X-Microsoft-Antispam-Message-Info: =?utf-8?B?NmxyanlrRElDTkV0Q0VRYXBUdTYxRXlsdjR6eEdqM3hneXZSV1BHc0cxVity?= =?utf-8?B?ZEd5S3lwb2pBTE9ZeE16NldRY3RoVDBHeFlsRjB5dy9FbDA3WktoWFR1aWh3?= =?utf-8?B?bERibUdzRjRXdmN6NEIxUEhYWDZUQ2VaRXpsZGlsRGV1c0N2cFc1dmxqaVhR?= =?utf-8?B?S1NWZGRUdnlzMURITFdiRnJjd1FSTEx5WllNL2pTUWdDMG1kTHQwODlCNlV3?= =?utf-8?B?YUNNUWI2YVZENi8vTmZWZUJNZ0Y1dGJmYzNxeVd5eCtzbkR0VDdLN3NaTmE2?= =?utf-8?B?YzJMUWR2Umt5dW4zZ0Q1Z2ZqcHdYTmMzMmRxc2o0TU9ESGYwQVA3MFB5di9N?= =?utf-8?B?STZyRXhrZHRTNGRHdUlVa0tteDBaM1BOQWVCb0hmT3hXNm4xVjBTbFQ0cnhn?= =?utf-8?B?eXkzWFhsSzhkckJsY2hqYks5Zy8rQTVzRmt6VGNqNTczNDNJalZCK1liNUVk?= =?utf-8?B?cXdrbVVLbnkydHF6UVJKeEVBdDU1YUZDTFFETWxkTW4vZlA4YlVzdHFIbldV?= =?utf-8?B?Nys4TzZoaFBYUlRlcjA4ZzVZd2ZSSHNnWWQwV2tTZktGcmNBNFE4eTREV25S?= =?utf-8?B?R2d4WGVXUTR1VWVac1hUK2dIbkNsdFJZQnB0OStia0JzN3dZYS9MdGF4MVlD?= =?utf-8?B?MnZ0UHExdU0xNkdycHZBNXBzMWpwenNQS1hsU2ZHNElBaXpMaUdzaitJZTRV?= =?utf-8?B?Q0Vjd0hBL3ZwT3M2RmZTVjRqMVdKSldOTE9Hb0thSWh0NkRLMWdvR1lCRjFl?= =?utf-8?B?TGNhMGNSeU0xdlRWbSsxRFJobnoxazJvT0ovQ1hNNmhkWDR1Y1RBclNMZ0dZ?= =?utf-8?B?alNGL1pTYUFkdkZOeWt1RUh2TmJwd3VUdWRZdXJwV1JBcW9uL1hpclpnZjZD?= =?utf-8?B?ZXZnaUhXU0tZKzU3UTNXdTRWeFBnVDhYZzBUWGZVNlYra3VVMFNLR3RMU2ds?= =?utf-8?B?dkFyOW9nRitwM2ovMFB3WWttbU1UR3Z4QXNRSU00VzJWZHZuZy8rckNvSmh1?= =?utf-8?B?My9vL2NjL1NONFVzQXBURTUzNHpYdS9HY1N5bEZ2a1hXRE4ydGtLNVdzRUZM?= =?utf-8?B?Q0pwRUd2c0I5emxrS2E3MWxZT0Jib1dDUnRFay9tUUcrNHg2ZUFqVzh4T05Q?= =?utf-8?B?eE5CU2NYSGFVUVBzakIvVTlEYXJkL1RNb2Z6NkZ3TUpqY2R0enFlOHIzK0pY?= =?utf-8?B?Q1ZIa2hBaGZUNW1uaUhndXBCOW1RTnRhQWozVVR0bGZGa0NFUHMxVWwvSDJX?= =?utf-8?B?UXJOQ0oraGYrYmF6NlI5STVVeEgrWjhiTDNtbXdHWlJSV3VPcVpBNk9FM1Ax?= =?utf-8?B?VFQwTm0xdGJ0bDFzUVBXVDVlUEFYREtqZkV6aUZLR2dReEwwYXh4NGl6S2tx?= =?utf-8?B?c0R5SkVUMEh2WkllL2dIN0pVUmJ1endtWjNUaERjWEdYZmxiM01TVmRNd0NP?= =?utf-8?B?ZmRJVkp1aDl2UEFWTkFnTFU1ZWtOeWJWQWE2VXlsOHFlVzBsVnc1TnFaa1pS?= =?utf-8?B?OE1lellJMlozTHZPWTVVYlA3TmxjMTFveGxFMTV0ZXoxSENEa1UxWlF1clND?= =?utf-8?B?QlFTYXVUUUxVeW9GS0dOTzNIZGxJY3FKczI1MEhkSjloZkxyNGJ3bFFOdSth?= =?utf-8?B?OERSUGovVDJaK1AwL2grRzJnODJiZ3E5eTB1R3Q4TjE1VnBVRmZQaGhCa09B?= =?utf-8?B?bEswaUVCMjF2UUVSNzZLV0lDbGIvNnRjWTJodTNybFdhRk9qTGpVNUZVOUpJ?= =?utf-8?B?T2QvcG9mYmFNOEVFRTRwY0sxZkQ1K3ZwZ2N1dUs4RzkyZHVyLzk5WnFVdERk?= =?utf-8?B?R1VqU1ZhaXdGMkVlK3daZz09?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR11MB7925.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(1800799024)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RStWVjAweWFSbEw2d3FkUE42bDRtYTQrL2xTY1hzWTJkazlnaHBGN1ZKUGZk?= =?utf-8?B?ODl1V2hUSGhKNVNOQXQ5aHoxUjYyNndGS2dvRVJLa2JBV29KQzNrUEwwN2Nx?= =?utf-8?B?M3JFMml0L0ViMWphdkJHay9EYnBXK2x0aVRtOXJSTnIyT2ZnSitwODNCOEF5?= =?utf-8?B?SEZTUGtjUmNwUXdHVGRRdVhkUGFHM3IydUEzSmxpWDJLeVVSd2ZYZFRhT0Fy?= =?utf-8?B?MmhiOVhvT2dVdzF6TFlMQVNrKzdlNXljZS9iejV1ZHZGVGVDc3BybEM5VW9n?= =?utf-8?B?aStKM0tlS1RlRVlva21VV1dUbHZJUlo4ZGtBTzVHMkFueVRqM0JpaitHMU1Q?= =?utf-8?B?RU9YcUU2cVg0cmJSYTlrNGNvUjg2ZHdSSnBvckZQZ29XM0dTdlNYbnNlaFEr?= =?utf-8?B?andmZFkxV09VeXF1YVBibkgvUmdEVUljOThSc0d2czIzeUx2bklrMkJDYW4r?= =?utf-8?B?S1BsVUhkWWNwMS9JcDJMWlNmZDJFenQ3VlRwR2RvRlc1L0JBOU9qVW91MzNS?= =?utf-8?B?NFZsUFpYbGo4b0ZDWGVwbS9ieUZKNXcxYURHSU9zOCtHZkUyalpjT3ZEdEJR?= =?utf-8?B?RnFTWTZSYmw0d1V6THBsUk9Na3BZakYvYVJWNzFXMHNZcFVuTmhMR2hPQ3Qx?= =?utf-8?B?Q3BNT0psT1RvUWxWTzQzSkY3NDdrV1BnWnN2WmY2eVpBQnZlRWZYc0RuamxB?= =?utf-8?B?TUNYL1lVQ2JtWlNyK3BkQ2NmUnI2bnVScHNlbUFsMWFwa2hBZ014L0MwVGNW?= =?utf-8?B?YXNjNkJ0MFJjenl5RjFPN3NNWUNrQnpVRktWUjFhU0xaOXY3S3RweTN1NmtY?= =?utf-8?B?L0VoazVRaHFPZ29rUW5KQk45NE1WVkxiZitNSXFUNVdLcmo1MUZjU3g1bVlJ?= =?utf-8?B?M2RTN1ZONkNLK1laRWI1ZnZLbWs0bTJKY1gvS3h4Mkc5MWs5TnFQeVlxWERZ?= =?utf-8?B?M2lKck1QODM4cWxrUjRxRU1MYUdlaGkyWXpWMTE4ekZqME9tYkc0aW9MVFM4?= =?utf-8?B?dER3eGVtRHFsWUdZWml0MFk0Njk4eERBUUY4RWJxRnViTSt0OGM3ZGxoZUV3?= =?utf-8?B?bGtndXY5QTJ1UVQvTjh3WFVaZnU2WGxmVTMvYUxhcWZla2kwUXRPZWh2QkVB?= =?utf-8?B?Z1h1aE9PYnlDOFdNK2xWM0h6V2JmN0FGcjgvSFJYaVMveFQyelVaNnl2b3ZJ?= =?utf-8?B?TGNOald6dGpyQk81NExTRzAyYnMzRm9MdThBRnArWjBYdE83S2tNUlkxLzNn?= =?utf-8?B?K0dFbE5VRDIxRW8yYitjTkQwNmx5V0dWbjhQSm9QcWt3MFcwZ0REd3pUYnBO?= =?utf-8?B?TW1CSlVPTnpmN21ibDk4Qkt0d0VSeDJoL25KT1FGaGN3aEQ0UU9MMnlsNHRy?= =?utf-8?B?WlZkdWlFNlZMbzhTQjExSExqOUdURmZJcVJ5L2lBR25CUm9NK2JUV2JuZ3Fi?= =?utf-8?B?MUVjWGJ3Qm9JVnJSNzhHS3l5WGo3WS9mVUFMNFNCaGJQSUo4ck5Jc2x4Y0lr?= =?utf-8?B?UmM5KzBLSkFyVGhkNENtblVIN09EbUlUck5XREErSU8yUnBmWlZLSS9MTmti?= =?utf-8?B?dHprM3VEQ2JIaGlxYlhDT2tuaVIyOGRmTitnMHlId2JsV1BkcktiNXE0REF6?= =?utf-8?B?UmJnR0Q2alBIa2NuZTdmUUNTbXY5M3pXck1KbFcvWTZCK24vcGJRbHVEbnYz?= =?utf-8?B?UlBhNiticmtCbGFBeTRzZEpoU3VqOEVReEg5RXdNMmRZSlVoUSszckVIOG92?= =?utf-8?B?Ym9OeWh4K2k3c2lXTFhhOCtOTVQzdm03bmRzZjRwSi8xTWFhb2lKZlkrQXdG?= =?utf-8?B?YWxTTEdjdnhScWtLQkRZTFVueEZ3UEN0dGFSOW5CS1c1WnVMQVV3Vk50SHIv?= =?utf-8?B?cGcyd0VBUUpUZ3RjQlBtRW1Va1JxU1R6RHVvTGhXNmgxZ0IzdjAyc3hKTElX?= =?utf-8?B?eisvcTgxRTlkOFFNZVViRk50clR4cUhKOXZvUTdYc2REeW1pcHEzMnRXQTJ1?= =?utf-8?B?bkN3ZmxVeVFaSGtTR2R1TkFXREpnNW5GY1daMmtqVjF2Q29EL08vSU95SVBB?= =?utf-8?B?djBSTnNsdWdhcFdlMUhVZFN5VjJJdldHRlROZGFRT3RMc1o0MVViSUl0dEVC?= =?utf-8?B?NlYrUWc4cFk5NnhRaHBEQ2htZ0Y1cUNjMFBwTzBCQlZBZWtPek5IMll6ZlJs?= =?utf-8?B?dmc9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: b24e1020-badd-41cd-8d4a-08dd374e163c X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7925.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jan 2025 23:24:27.8277 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: FZWU4MoajZhK73uMa0zkoM/cp0Cke/roqU4ha7xnDYk7GHjY4PRvd+0HHJsbNGqBPj7nhZBL6pGXOwZl0niWpSvB2resblThF1HxANHBH7s= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR11MB6234 X-OriginatorOrg: intel.com On 1/17/2025 2:10 PM, Sean Christopherson wrote: > > I don't see anything in the SDM that suggests this is a misconfigured CPU. Intel > might not have plans to ship such CPUs, but AFAICT it's not a violation of the > architecture as defined in the SDM. > > The SDM even explicitly says that protection keys can exist and be used without > PKU state being supported in XSAVE at all, at which point assuming the existence > of XGETBV1 is rather nonsensical. > > XCR0[9] is associated with PKRU state (see Section 13.5.7). Software can use > the XSAVE feature set to manage PKRU state only if XCR0[9] = 1. The value of > XCR0[9] in no way determines whether software can use protection keys or execute > other instructions that access PKRU state (these instructions can be executed even > if XCR0[9] = 0). > > XCR0[9] is 0 coming out of RESET. As noted in Section 13.2, a processor allows > software to set XCR0[9] if and only if CPUID.(EAX=0DH,ECX=0):EAX[9] = 1. Yeah, right. Furthermore, looking further at the update_pkru_in_sigframe() change, I doubt the xfeatures_in_use() invocation is really necessary. The change seems to always write the PKRU state in the signal frame and set the PKRU bit. Since XSAVE has already been performed, the latter could be something like this: __get_user(xstate_bv, &buf->header.xfeatures); xstate_bv |= XFEATURE_MASK_PKRU; __put_user(xstate_bv, &buf->header.xfeatures); A similar code is already there for FP/SSE bits in the save_xstate_epilog() function: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/x86/kernel/fpu/signal.c#n139 Thanks, Chang