From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4EE194014A4 for ; Tue, 5 May 2026 11:20:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=13.77.154.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777980023; cv=none; b=pzSlqG9sk+EXpDPbcgFg7IV9mbNf3Zv9hVpXdzXkbWJAdCM/XVpttKgxReYlPPXj5WU84UqdOKatxHZKb3rsGTQ3sBTvydxTbMeC0UbDhYciL57hzySbcpRjM5JNl6+BOkTfphWY0FYmuoyACyvSjLI5WslzihL1HpA2Z2eL6EA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777980023; c=relaxed/simple; bh=6tVLA5UVrXX7YoA+vVyzzWlW+jfWScwBgWY09HQNls0=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References: MIME-Version:Content-Type; b=r1Neo3OkyOxQxSAGGLIDJSkM++7eep2W4DIKDdmGOMxnOFfifg6RF7Uj9YiyWP2eMfRnnh5WEVKolMARo7hvhIhMLXvGlYcPDrIkC008A0d3sxgB9n519+kbaxZnpaJ9guegP3L2mrkTZxClpBaeIfvkXLUHjT8zuHtBs3PsX3c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com; spf=pass smtp.mailfrom=linux.microsoft.com; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b=Rzjpi7Sd; arc=none smtp.client-ip=13.77.154.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.microsoft.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b="Rzjpi7Sd" Received: by linux.microsoft.com (Postfix, from userid 1241) id 83AAE20B7168; Tue, 5 May 2026 04:20:14 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 83AAE20B7168 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1777980014; bh=824fW5VJr8kTEo1jJkOZf4ojp49EPJyPH98EoCje4gY=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=Rzjpi7SdVJZIrHd8F1XZbdFYMgpviBEKJ9wdzkwTw404HGuXrwUI0I50BkqAiZ8ka 08+/SBwTb7ENqqQpB2BhnssImDOK9lUDTn7wT7j58y66gF4LlhEkCOhBB721orvceK +aKRujSg79KZfyURyOjNbesUXdDqswHSRbG1pGVw= Received: from localhost (localhost [127.0.0.1]) by linux.microsoft.com (Postfix) with ESMTP id 8189E30705A3; Tue, 5 May 2026 04:20:14 -0700 (PDT) Date: Tue, 5 May 2026 04:20:14 -0700 (PDT) From: Jork Loeser To: Pratyush Yadav cc: Mike Rapoport , Pasha Tatashin , Alexander Graf , Muchun Song , Oscar Salvador , David Hildenbrand , Andrew Morton , Jason Miu , kexec@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 01/12] kho: generalize radix tree APIs In-Reply-To: <20260429133928.850721-2-pratyush@kernel.org> Message-ID: <331da42-b255-326b-cd5-28d07a7e2cb2@linux.microsoft.com> References: <20260429133928.850721-1-pratyush@kernel.org> <20260429133928.850721-2-pratyush@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed On Wed, 29 Apr 2026, Pratyush Yadav wrote: > From: "Pratyush Yadav (Google)" > > The KHO radix tree is a data structure that can track the presence or > absence of an arbitrary key, with nothing inherently tied to KHO memory > preservation tracking. This was one of the design goals of the radix > tree. This was done to enable it to be re-used by other users of KHO. "Arbitrary key": Not quite the complete 64-bits, rather 64 - PAGE_SIZE, correct? > + * kho_radix_add_key - Add a key to the radix tree. > * @tree: The KHO radix tree. > + * @key: The key to add. > * > + * This function traverses the radix tree based on the key provided. It sets the > + * corresponding bit in the leaf bitmap to mark the key as present. If > + * intermediate nodes do not exist along the path, they are allocated and added > + * to the tree. Consider adding a note on the key-width limitation. Best, Jork