public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Jacob Pan <jacob.jun.pan@linux.intel.com>
Cc: Linux PM <linux-pm@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Rafael Wysocki <rafael.j.wysocki@intel.com>,
	Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
	Len Brown <len.brown@intel.com>
Subject: Re: [PATCH] powercap/rapl: handle domain energy unit
Date: Thu, 12 Mar 2015 23:24:56 +0100	[thread overview]
Message-ID: <3326586.77vrRRoRJD@vostro.rjw.lan> (raw)
In-Reply-To: <20150312131739.4dbef312@icelake>

On Thursday, March 12, 2015 01:17:39 PM Jacob Pan wrote:
> On Wed, 11 Mar 2015 23:01:30 +0100
> "Rafael J. Wysocki" <rjw@rjwysocki.net> wrote:
> 
> > On Wednesday, March 11, 2015 05:55:09 AM Jacob Pan wrote:
> > > The current driver assumes all RAPL domains within a CPU package
> > > have the same energy unit. This is no longer true for HSW server
> > > CPUs since DRAM domain has is own fixed energy unit which can be
> > > different than the package energy unit enumerated by package
> > > power MSR. In fact, the default HSW EP package power unit is 61uJ
> > > whereas DRAM domain unit is 15.3uJ. The result is that DRAM power
> > > consumption is counted 4x more than real power reported by energy
> > > counters.
> > > 
> > > This patch adds domain specific energy unit per cpu type, it allows
> > > domain energy unit to override package energy unit if non zero.
> > > 
> > > Signed-off-by: Jacob Pan <jacob.jun.pan@linux.intel.com>
> > 
> > Should I regard this as a fix for 4.0?  If so, should it also go to
> > "stable" (and which "stable" series should it go to in that case)?
> > 
> yes, it is a bug fix. I think this should be applied to all stable
> kernels since RAPL driver was merged. So 3.10.71 and later.

OK


      reply	other threads:[~2015-03-12 22:01 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-11 12:55 [PATCH] powercap/rapl: handle domain energy unit Jacob Pan
2015-03-11 21:25 ` kazutomo
2015-03-12 21:24   ` Jacob Pan
2015-03-12 21:59     ` kazutomo
2015-03-12 22:05       ` Jacob Pan
2015-03-12 22:50         ` kazutomo
2015-03-13 10:53           ` Jacob Pan
2015-03-11 22:01 ` Rafael J. Wysocki
2015-03-12 20:17   ` Jacob Pan
2015-03-12 22:24     ` Rafael J. Wysocki [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3326586.77vrRRoRJD@vostro.rjw.lan \
    --to=rjw@rjwysocki.net \
    --cc=jacob.jun.pan@linux.intel.com \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rafael.j.wysocki@intel.com \
    --cc=srinivas.pandruvada@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox