Re: Re: [PATCH 0/3] power: max17042_battery: Add DT bindings

[함명주 <myungjoo.ham@samsung.com>]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=euc-kr, Size: 2576 bytes --]

Dear Karol Lewandowski,

I've been confused this patchset with Dirk Brandewie's MAX17042 patchset; I though this was a follow-up version of Dirk's, which I think already acked by me.

Anyway, the patches themselves look fine.

However, have you checked the compatibility (mergability?) with the recent MAX17042 patches of Dirk Brandewie? I'm not sure about the merge status of Dirk's patchset, but, I think you need to consider his patches as they massively reshaped the device driver.

Other than that, the patches look fine. (If that issue is already considered, regard this as an Acked-by.)

Thank you.


Cheers!
MyungJoo.

------- Original Message -------
Sender : Karol Lewandowski<k.lewandowsk@samsung.com> Junior Software Engineer/SPRC-Linux (MSD)/»ï¼ºÀüÀÚ
Date : 2012-03-08 19:32 (GMT+09:00)
Title : Re: [PATCH 0/3] power: max17042_battery: Add DT bindings

Dear MyungJoo Ham,

Could you take a look at patchset I've sent? It's needed to make use of
max17042 driver on device tree-enabled platforms.

Regards,
-- 
Karol Lewandowski | Samsung Poland R&D Center | Linux/Platform

On 22.02.2012 19:06, Karol Lewandowski wrote:

> Hi,
> 
> This series of patches adds bindings to max17042_battery driver making
> it possible to instantiate it from device tree description.
> 
> First, convience patch, simply replaces kzalloc with devm_kzalloc
> where possible.
> 
> Second, most intrusive patch adds variables orginally found only in
> platform data to max17042_chip structure.  I decided it to do it that
> way rather than allocating new platform data and then populating it
> from device tree description.
> 
> Last patch adds DT bindings itself.
> 
> I would be grateful for any comments and I will be more than happy to
> rework this patchset if needed.
> 
> 
> Karol Lewandowski (3):
>   max17042_battery: Use devm_kzalloc() where applicable
>   max17042_battery: Preserve properties outside of platform data
>   max17042_battery: Make it possible to instantiate driver from DT
> 
>  .../bindings/power_supply/max17042_battery.txt     |   18 +++++
>  drivers/power/max17042_battery.c                   |   77 ++++++++++++++++----
>  2 files changed, 79 insertions(+), 16 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/power_supply/max17042_battery.txt
> 






--
MyungJoo Ham (ÇÔ¸íÁÖ), PHD
System S/W Lab, S/W Platform Team, Software Center
Samsung Electronics
Cell: +82-10-6714-2858ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥