Re: [PATCH v1 1/3] cgroup/rstat: add cgroup_rstat_lock helpers and tracepoints

Simon Horman
2024-04-23T16:55:26Z

On Tue, Apr 16, 2024 at 07:51:26PM +0200, Jesper Dangaard Brouer wrote:

...

> /**
> * cgroup_rstat_flush_release - release cgroup_rstat_flush_hold()
> */

Hi Jesper,

as a follow-up could you add an entry for cgrp to the kernel doc above?

> -void cgroup_rstat_flush_release(void)
> +void cgroup_rstat_flush_release(struct cgroup *cgrp)
> __releases(&cgroup_rstat_lock)
> {
> - spin_unlock_irq(&cgroup_rstat_lock);
> + __cgroup_rstat_unlock(cgrp, -1);
> }

...