From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1B58A3D1716 for ; Wed, 11 Mar 2026 10:52:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773226348; cv=none; b=vB9DHCtkTc8s1T4ExrYHT/R+zLSoKsklAKw0QmlywUaK7kqO5N7iPPn7Cz8bXp1ODBZkvBC5TVuJIoDGLc0+VYNZeLJZTJx0eoQ+f25eOeldklwrBaxS/xF+iO3uPcSWq1cqAN726D0v5YhyzDZEmYxtT0qcO2H6PCNZP3lTfIE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773226348; c=relaxed/simple; bh=VTFbGjqMuCilNHDxgvaQ2CTafhfYnCrd0sXbQe7PI8c=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=KOmU9t9PUzS4eRDAhfxSz7SGEIkLh3CVXDG3+mwR+qQkiPGZ2WtA7pUVLM7Cn+KIXmXI0XQT5VOf0oxSXA/Lx/6UZxWO1/VJsGSwCc7SrbGD2i7aVBTOYHh4FRNBDpI+1/+G1asSCAzkNMe62Wh+GwsuQ4IcYYxQwb9qYv/4CT8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HaSpd3xX; arc=none smtp.client-ip=209.85.210.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HaSpd3xX" Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-829759ca646so3905098b3a.2 for ; Wed, 11 Mar 2026 03:52:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773226345; x=1773831145; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=LPTO/kKMdzOm1yb4HExAVv5DEVkwKacMrp7m0gdsATQ=; b=HaSpd3xXDX16q4GBUGcfxoIEdELCiJ03UWkTdU53HjcZGnsbR1ACyNdYWqkMf7LSIQ R4gc6J3pfGnv/0c96kdCI1ItHfcC0ZGMnI6FC3LZovDrNu/jRN/CToZ3JIzVipGE6eGZ MUuWRebr5z2Hx/sPnmhZg8MO9iyMIXch7rRSM/YnZv0AVrrI3nLeGlwTxtzXs9WMvemC yVu0WArwzIp1uUZ86uTGYypkS23aseuC/M9IOK9CkO78738aIuVR7EPRnkmAEfruq3jQ H3oAfIoXAYIIwSRH76dKC3oUEZ6HeYPD8MiTkoc1fQ8lLG+BKJA+vREb5bpLxfZFhrQh ZphQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773226345; x=1773831145; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=LPTO/kKMdzOm1yb4HExAVv5DEVkwKacMrp7m0gdsATQ=; b=tlkwVfa+IXJRWasVjSSixrh7PH7CIK7/e8MuFCWQLXu+3XYfjf+k9E5t8Jo2O853dN JCtuxZiSNwPFeKCa6W8YT1Bi5H9xt7/qyijp+ZFoNkUfdUmgnoe3G4sJuCBEhjxSG45R 4kZbd+dZz6SNF1DBIpFqVBrvcmiFUYNZvVaGfKqz8WWWogz3PeQPSQDs/2fop3PLcSrr sTeiiTIqzMShCDZ1YHPK2hIM1jNEzQAorLuIma8OkBIlWPlCvD2C3K0OvRzeZZi6i27Y REbiZ2GUm2iWll1pScehkfUPm6Ex20ktqz405jVZdmi8jzsFdsmzbhdWaQU7phI0/QxR 1rlg== X-Forwarded-Encrypted: i=1; AJvYcCVUTisdC3SkHalBBPWmpWz5oWOkMAIX79GXqVyNu/fWeNbXyhfrj1npiPZLkqVKPs5+TtABm1sc5R+v0DE=@vger.kernel.org X-Gm-Message-State: AOJu0Yxyl3HAp/q/uolGmIoV65jX7FFCnuM1W6lSXz5Po4vH5KwHwGVy APv0GJH/tkyXGIqxN64vcen2jpnO0sW27vh9gkMexO1gShC8QmzyRIgr X-Gm-Gg: ATEYQzwakqAsOYnUiXpju6OFciEL7zL3auirFeSmxhfQNBawehKIKfekTPjnuHVxP7u i6SJaU1URUVHEp+EL6U6qYKA73YCl6M4tT1PtVQOwk5mvIxE1RgpUhlbUZsQki0synir/0fFx2K PPo0mmllPLxMY2eDszIplh7Swj7MwRsXi+Fw0mdTvNVybJasqra17KGjq8FxT+Lg07o2ew8BxvQ ZC5G9ZIlOywavtGk7Etb7V2dM2fDjP27uzGeqem9jKVLgseXjPMCiQk7KkLylcFU1Z0PspY7R4+ gOt96doiO71cDvhWcK9lSvYW8nmFCwj4Y6PgEoi2eCCFUA9b/zU8fRmWH5Yh0OxCzt68OnfliNv Mq4mOXb0tYNnfY4XB8Y3to65hUch7HZoZUI1SCJc3K0P336nJfI2e45tAfFHDkvBjrKA7Js0ReK Hp+xZl2GOsNotxE65XDu3Z46i+kmkK83Ylz3J1W0JCFfR1KExwHhspUYD6CnwnAbXYPNvJ9Xc8j diTFFvXoNgW1TqvSNganRf+w1T1cvuijZrZNRKShq3wSlfge0MoMkbdwf8RGaMoVbw9CTiz9quK xD7j+vE0rfVayw== X-Received: by 2002:a05:6a00:9510:b0:823:c59:9cb0 with SMTP id d2e1a72fcca58-829f707348bmr2146847b3a.1.1773226345365; Wed, 11 Mar 2026 03:52:25 -0700 (PDT) Received: from minako.localnet ([2403:581e:d87e:0:739f:50a5:e171:f133]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-829f6df32a6sm2255620b3a.14.2026.03.11.03.52.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Mar 2026 03:52:24 -0700 (PDT) From: James Calligeros To: Mark Brown Cc: David Rhodes , Richard Fitzgerald , Martin =?UTF-8?B?UG92acWhZXI=?= , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , asahi@lists.linux.dev, linux-sound@vger.kernel.org, patches@opensource.cirrus.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ASoC: codecs: cs42l84: set up PLL for more sample rates Date: Wed, 11 Mar 2026 20:52:18 +1000 Message-ID: <3333069.e9J7NaK4W3@minako> In-Reply-To: References: <20260307-cs42l84-rates-v1-1-1c55a5673031@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Hi Mark, On Wednesday, 11 March 2026 4:51:25=E2=80=AFam Australian Eastern Standard = Time Mark=20 Brown wrote: > These are adding 44.1kHz based rates with a new value for MCLK (the > final value in each entry). Those values are read with a switch > statement in cs42l84_pll_config but that only has an entry for 24.576MHz > for some reason, that won't match 112.896MHz and will just leave the > pll_mclk_f with whatever value it had before. Don't we need a new case > statement there for the new MCLK? Yes and no. According to the datasheet, the chip only requires the PLL to be in the "region" of 12 or 24 MHz. Since we only have 12 MHz region PLL confi= gs in our table, this does actually work without changes, albeit unintutitively (and accidentally). On 42L42, this is configured using the MCLKDIV and MCLK_SRC_SEL bits, which behave identically to what we've ended up calling MCLK_F. I will add an explicit arm to the case statement and a comment explaining this so that it= is not ambiguous. Regards, James