public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Linux PM <linux-pm@vger.kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Lukasz Luba <lukasz.luba@arm.com>,
	Zhang Rui <rui.zhang@intel.com>,
	Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Subject: [PATCH v2 01/12] thermal: core: Initialize thermal zones before registering them
Date: Fri, 04 Oct 2024 21:05:49 +0200	[thread overview]
Message-ID: <3336146.44csPzL39Z@rjwysocki.net> (raw)
In-Reply-To: <2215082.irdbgypaU6@rjwysocki.net>

From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

Since user space can start interacting with a new thermal zone as soon
as device_register() called by thermal_zone_device_register_with_trips()
returns, it is better to initialize the thermal zone before calling
device_register() on it.

Fixes: d0df264fbd3c ("thermal/core: Remove pointless thermal_zone_device_reset() function")
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---

This is a new iteration of

https://lore.kernel.org/linux-pm/10527854.nUPlyArG6x@rjwysocki.net/

v1 -> v2: Fix typo in the subject

---
 drivers/thermal/thermal_core.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-pm/drivers/thermal/thermal_core.c
===================================================================
--- linux-pm.orig/drivers/thermal/thermal_core.c
+++ linux-pm/drivers/thermal/thermal_core.c
@@ -1465,6 +1465,7 @@ thermal_zone_device_register_with_trips(
 		thermal_zone_destroy_device_groups(tz);
 		goto remove_id;
 	}
+	thermal_zone_device_init(tz);
 	result = device_register(&tz->device);
 	if (result)
 		goto release_device;
@@ -1503,7 +1504,6 @@ thermal_zone_device_register_with_trips(
 
 	mutex_unlock(&thermal_list_lock);
 
-	thermal_zone_device_init(tz);
 	/* Update the new thermal zone and mark it as already updated. */
 	if (atomic_cmpxchg(&tz->need_update, 1, 0))
 		thermal_zone_device_update(tz, THERMAL_EVENT_UNSPECIFIED);




  reply	other threads:[~2024-10-04 19:43 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-04 19:01 [PATCH v2 00/12] thermal: core: Fixes and cleanups, mostly related to thermal zone init and exit Rafael J. Wysocki
2024-10-04 19:05 ` Rafael J. Wysocki [this message]
2024-10-21 22:16   ` [PATCH v2 01/12] thermal: core: Initialize thermal zones before registering them Lukasz Luba
2024-10-04 19:09 ` [PATCH v2 02/12] thermal: core: Rearrange PM notification code Rafael J. Wysocki
2024-10-21 22:18   ` Lukasz Luba
2024-10-04 19:11 ` [PATCH v2 03/12] thermal: core: Represent suspend-related thermal zone flags as bits Rafael J. Wysocki
2024-10-21 22:23   ` Lukasz Luba
2024-10-04 19:15 ` [PATCH v2 04/12] thermal: core: Mark thermal zones as initializing to start with Rafael J. Wysocki
2024-10-21 22:26   ` Lukasz Luba
2024-10-04 19:19 ` [PATCH v2 05/12] thermal: core: Fix race between zone registration and system suspend Rafael J. Wysocki
2024-10-21 22:27   ` Lukasz Luba
2024-10-04 19:23 ` [PATCH v2 06/12] thermal: core: Consolidate thermal zone locking during initialization Rafael J. Wysocki
2024-10-21 22:30   ` Lukasz Luba
2024-10-04 19:26 ` [PATCH v2 07/12] thermal: core: Mark thermal zones as exiting before unregistration Rafael J. Wysocki
2024-10-21 22:31   ` Lukasz Luba
2024-10-04 19:30 ` [PATCH v2 08/12] thermal: core: Consolidate thermal zone locking in the exit path Rafael J. Wysocki
2024-10-21 22:33   ` Lukasz Luba
2024-10-04 19:33 ` [PATCH v2 09/12] thermal: core: Update thermal zones after cooling device binding Rafael J. Wysocki
2024-10-21 22:35   ` Lukasz Luba
2024-10-04 19:35 ` [PATCH v2 10/12] thermal: core: Drop need_update field from struct thermal_zone_device Rafael J. Wysocki
2024-10-21 22:36   ` Lukasz Luba
2024-10-04 19:39 ` [PATCH v2 11/12] thermal: core: Move lists of thermal instances to trip descriptors Rafael J. Wysocki
2024-10-21 22:44   ` Lukasz Luba
2024-10-04 19:42 ` [PATCH v2 12/12] thermal: core: Pass trip descriptors to trip bind/unbind functions Rafael J. Wysocki
2024-10-21 22:37   ` Lukasz Luba
2024-10-11 18:50 ` [PATCH v2 00/12] thermal: core: Fixes and cleanups, mostly related to thermal zone init and exit Rafael J. Wysocki
2024-10-21 11:05   ` Rafael J. Wysocki
2024-10-21 22:45     ` Lukasz Luba
2024-10-22  9:56       ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3336146.44csPzL39Z@rjwysocki.net \
    --to=rjw@rjwysocki.net \
    --cc=daniel.lezcano@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=lukasz.luba@arm.com \
    --cc=rui.zhang@intel.com \
    --cc=srinivas.pandruvada@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox