From: Timur Tabi <ttabi@nvidia.com>
To: Ben Skeggs <bskeggs@nvidia.com>,
"dan.carpenter@linaro.org" <dan.carpenter@linaro.org>
Cc: "kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>,
"airlied@redhat.com" <airlied@redhat.com>,
Jon Hunter <jonathanh@nvidia.com>,
"lyude@redhat.com" <lyude@redhat.com>,
"baolu.lu@linux.intel.com" <baolu.lu@linux.intel.com>,
"simona@ffwll.ch" <simona@ffwll.ch>,
"airlied@gmail.com" <airlied@gmail.com>,
"thierry.reding@gmail.com" <thierry.reding@gmail.com>,
"dakr@kernel.org" <dakr@kernel.org>,
"nouveau@lists.freedesktop.org" <nouveau@lists.freedesktop.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>
Subject: Re: [PATCH next] drm/nouveau/tegra: Fix error pointer vs NULL return in nvkm_device_tegra_resource_addr()
Date: Fri, 23 May 2025 20:18:17 +0000 [thread overview]
Message-ID: <334404bdf60765cb5a8e855a74c688bc537531ee.camel@nvidia.com> (raw)
In-Reply-To: <aDCdXk98AhLBcWvK@stanley.mountain>
On Fri, 2025-05-23 at 19:07 +0300, Dan Carpenter wrote:
> The nvkm_device_tegra_resource() function returns a mix of error pointers
> and NULL. The callers only expect it to return NULL on error. Change it
> to only return NULL.
>
> Fixes: 76b8f81a5b92 ("drm/nouveau: improve handling of 64-bit BARs")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Timur Tabi <ttabi@nvidia.com>
prev parent reply other threads:[~2025-05-23 20:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-23 16:07 [PATCH next] drm/nouveau/tegra: Fix error pointer vs NULL return in nvkm_device_tegra_resource_addr() Dan Carpenter
2025-05-23 20:18 ` Timur Tabi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=334404bdf60765cb5a8e855a74c688bc537531ee.camel@nvidia.com \
--to=ttabi@nvidia.com \
--cc=airlied@gmail.com \
--cc=airlied@redhat.com \
--cc=baolu.lu@linux.intel.com \
--cc=bskeggs@nvidia.com \
--cc=dakr@kernel.org \
--cc=dan.carpenter@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jonathanh@nvidia.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=lyude@redhat.com \
--cc=nouveau@lists.freedesktop.org \
--cc=simona@ffwll.ch \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox