From: Janusz Krzysztofik <jmkrzyszt@gmail.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
linux-kernel@vger.kernel.org, Alexander Shiyan <shc_work@mail.ru>,
Haojian Zhuang <haojian.zhuang@gmail.com>,
Aaro Koskinen <aaro.koskinen@iki.fi>,
Tony Lindgren <tony@atomide.com>,
Mike Rapoport <rppt@linux.vnet.ibm.com>,
Robert Jarzmik <robert.jarzmik@free.fr>,
Philipp Zabel <philipp.zabel@gmail.com>,
Petr Cvek <petr.cvek@tul.cz>,
Paul Parsons <lost.distance@yahoo.com>,
Daniel Mack <zonque@gmail.com>,
Marc Zyngier <marc.zyngier@arm.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Russell King <rmk+kernel@armlinux.org.uk>
Subject: Re: [PATCH 2/5 v7] regulator: fixed/gpio: Pull inversion/OD into gpiolib
Date: Fri, 30 Nov 2018 02:28:36 +0100 [thread overview]
Message-ID: <3345160.3ImKfB1b4q@z50> (raw)
In-Reply-To: <20181119071126.8889-2-linus.walleij@linaro.org>
Hi Linus,
On Monday, November 19, 2018 8:11:23 AM CET Linus Walleij wrote:
> This pushes the handling of inversion semantics and open drain
> settings to the GPIO descriptor and gpiolib. All affected board
> files are also augmented.
>
> This is especially nice since we don't have to have any
> confusing flags passed around to the left and right littering
> the fixed and GPIO regulator drivers and the regulator core.
> It is all just very straight-forward: the core asks the GPIO
> line to be asserted or deasserted and gpiolib deals with the
> rest depending on how the platform is configured: if the line
> is active low, it deals with that, if the line is open drain,
> it deals with that too.
>
> Cc: Janusz Krzysztofik <jmkrzyszt@gmail.com> # OMAP1
Tested-by: Janusz Krzysztofik <jmkrzyszt@gmail.com> #OMAP1 Amstrad Delta
Thanks,
Janusz
next prev parent reply other threads:[~2018-11-30 1:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-19 7:11 [PATCH 1/5 v7] regulator: gpio: Convert to use descriptors Linus Walleij
2018-11-19 7:11 ` [PATCH 2/5 v7] regulator: fixed/gpio: Pull inversion/OD into gpiolib Linus Walleij
2018-11-30 1:28 ` Janusz Krzysztofik [this message]
2018-11-19 7:11 ` [PATCH 3/5 v7] regulator: fixed/gpio: Update device tree bindings Linus Walleij
2018-11-19 7:11 ` [PATCH 4/5 v7] regulator: gpio: Simplify probe path Linus Walleij
2018-11-19 7:11 ` [PATCH 5/5 v7] regulator: core: Only support passing enable GPIO descriptors Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3345160.3ImKfB1b4q@z50 \
--to=jmkrzyszt@gmail.com \
--cc=aaro.koskinen@iki.fi \
--cc=broonie@kernel.org \
--cc=geert+renesas@glider.be \
--cc=haojian.zhuang@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lost.distance@yahoo.com \
--cc=marc.zyngier@arm.com \
--cc=petr.cvek@tul.cz \
--cc=philipp.zabel@gmail.com \
--cc=rmk+kernel@armlinux.org.uk \
--cc=robert.jarzmik@free.fr \
--cc=rppt@linux.vnet.ibm.com \
--cc=shc_work@mail.ru \
--cc=tony@atomide.com \
--cc=zonque@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox