From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+w=401wt.eu-S1759730AbYHAUgm@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1759730AbYHAUgm (ORCPT <rfc822;w@1wt.eu>);
	Fri, 1 Aug 2008 16:36:42 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756420AbYHAUgY
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Fri, 1 Aug 2008 16:36:24 -0400
Received: from agminet01.oracle.com ([141.146.126.228]:29414 "EHLO
	agminet01.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1755884AbYHAUgX (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 1 Aug 2008 16:36:23 -0400
Message-ID: <33469382.1217622974098.JavaMail.oracle@acsmt303.oracle.com>
Date: Fri, 1 Aug 2008 15:36:14 -0500 (CDT)
From: Randy Dunlap <randy.dunlap@oracle.com>
To: Greg KH <greg@kroah.com>
Subject: Re: linux-next: Tree for August 1 (sysfs.h)
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
       LKML <linux-kernel@vger.kernel.org>, linux-next@vger.kernel.org
In-Reply-To: <20080801182612.GB4788@kroah.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 7bit
References: <20080801165808.68f833ec.sfr@canb.auug.org.au> <20080801111452.1b4c55d3.randy.dunlap@oracle.com> <20080801182612.GB4788@kroah.com>
X-Priority: 3
X-Mailer: Oracle Webmail Client(UIX)
Content-Language: en-US
Accept-Language: en-US
X-Brightmail-Tracker: AAAAAQAAAAI=
X-Brightmail-Tracker: AAAAAQAAAAI=
X-Whitelist: TRUE
X-Whitelist: TRUE
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> > When CONFIG_SYSFS=n:
> > 
> >   CC      arch/x86/kernel/asm-offsets.s
> > In file included from linux-next-20080801/include/linux/kobject.h:21,
> >                  from linux-next-20080801/include/linux/module.h:16,
> >                  from linux-next-20080801/include/linux/crypto.h:21,
> >                  from linux-next-20080801/arch/x86/kernel/asm-offsets_64.c:7,
> >                  from linux-next-20080801/arch/x86/kernel/asm-offsets.c:4:
> > linux-next-20080801/include/linux/sysfs.h:247: error: return type is an incomplete type
> > linux-next-20080801/include/linux/sysfs.h: In function 'sysfs_get':
> > linux-next-20080801/include/linux/sysfs.h:248: warning: 'return' with a value, in function returning void
> > make[2]: *** [arch/x86/kernel/asm-offsets.s] Error 1
> 
> Ah, missed a "*".  It's Neil's fault :)
> 
> I'll go fix this up, it's for when CONFIG_SYSFS is set to N,
> right?

see line 1 above.