From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755311AbcIJUc1 (ORCPT ); Sat, 10 Sep 2016 16:32:27 -0400 Received: from mout.web.de ([217.72.192.78]:52648 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753141AbcIJUcZ (ORCPT ); Sat, 10 Sep 2016 16:32:25 -0400 Subject: [PATCH 09/13] DRBD-receiver: Improve determination of sizes in receive_SyncParam() To: drbd-dev@lists.linbit.com, Lars Ellenberg , Philipp Reisner References: <3566e764-27b8-82e5-1f8e-c613e5a3a5b1@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: SF Markus Elfring Message-ID: <334ae3df-8fff-025b-5311-af4522d9611f@users.sourceforge.net> Date: Sat, 10 Sep 2016 22:32:17 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <3566e764-27b8-82e5-1f8e-c613e5a3a5b1@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:vakPLxNJfQYUAQuoqPfskUmQy/Qtiqb4syqlRrvJL0oSgQJ6CzC PhYu7+/YgsMf26onSouf3Ie5bV9WnjAmJpJm7p9kn59envxbRJTc78WOx7X36HM8W0ocypg EKMBbSnK7pCY4rRFdUFhOWMxhXsvJCAURzfpiGQG8miqoZU/A5auPv8BuUS8NgDKIkqxo2p 9XT7Xqk+TVpW1jtReGAnA== X-UI-Out-Filterresults: notjunk:1;V01:K0:sSyQHIOEW0E=:KUl2xqy4/6FyN6oJlEIwcD n8lkHnlqwgTZVF+i1FEz6joq9f067KATStTIhUxQDRPTb8CTW5yu/ypkic2rBTaerPO96rnNB 3Yve0WttNm6JBveXw784GfvqLsZm+tK68M5RgHbXUEkpWkTGaYTX2pME6lGxxMhSoNRRGrJ3h GR3TYBZiAJt1xDQdO6//SDScanryV5BzE6hKZm41mBLVuAjTC09IkoJ2p8RA8JOm5TVtDoCp3 A9porxQbkwTbFZJVzTfQ8FIcHsRbMDXiJi5TxLIeId91WbQgJEWZzkG5jpcDbhoQ+PAsTbkqi 3K9wSO2WcpZWs4xrsWSPQqbzjOg3tYezLAPN3P/eIffusEAwx4XkFObPNQ0QtbeM8CVFxr5GV WknfZftlpBfnog/7SlNjSEOehheDvAZ2iqQ6mxFoPmTeggaLaa2xErqOdcmtvAlStKpqACvAX Ul9d1mm6Jl3K60xkdt9P7/tNpjuXVVYDlBLjpdL4pFQ47xCMQFMW/rDucAvmzbqiE9HUIKdJU OfnKVWLfwzLxWLs6DGw7ur9IPbOrnQb7X++iYAE+N3AhcLBDfz66Hym0Lg3PRBp2lR15uVU/3 JG/ayN90Z7zzHlUx4A4GXoVmP+osn9caCwbAawbl3IE/ABCXFrBMfGXzl5rcg0+9fg1T7RqMB 7i/kvYNvytf7ctKkV7MSBXmDfUnTS6o1rkG97t1u0al2+bckbOPteTGfJr3icQ/Kvzcamr4mf 0j2rI6sh2PZkKN4GJIkNTum4+dGyu216+ZInhzWFVoD+OUHLUWaPPScam/0QZlQU+o4DKUpfN 9HaISLy Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sat, 10 Sep 2016 21:54:55 +0200 Replace the specification of data structures by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring --- drivers/block/drbd/drbd_receiver.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/block/drbd/drbd_receiver.c b/drivers/block/drbd/drbd_receiver.c index 2fe58d1..6fbd968 100644 --- a/drivers/block/drbd/drbd_receiver.c +++ b/drivers/block/drbd/drbd_receiver.c @@ -3859,7 +3859,7 @@ static int receive_SyncParam(struct drbd_connection *connection, struct packet_i mutex_lock(&connection->resource->conf_update); old_net_conf = peer_device->connection->net_conf; if (get_ldev(device)) { - new_disk_conf = kzalloc(sizeof(struct disk_conf), GFP_KERNEL); + new_disk_conf = kzalloc(sizeof(*new_disk_conf), GFP_KERNEL); if (!new_disk_conf) { put_ldev(device); mutex_unlock(&connection->resource->conf_update); @@ -3946,7 +3946,8 @@ static int receive_SyncParam(struct drbd_connection *connection, struct packet_i } if (verify_tfm || csums_tfm) { - new_net_conf = kzalloc(sizeof(struct net_conf), GFP_KERNEL); + new_net_conf = kzalloc(sizeof(*new_net_conf), + GFP_KERNEL); if (!new_net_conf) { drbd_err(device, "Allocation of new net_conf failed\n"); goto disconnect; -- 2.10.0