From: Jiri Slaby <jirislaby@kernel.org>
To: Allen Pais <apais@linux.microsoft.com>, linux-kernel@vger.kernel.org
Cc: tj@kernel.org, keescook@chromium.org, gregkh@linuxfoundation.org,
richard.genoud@gmail.com, linux-serial@vger.kernel.org
Subject: Re: [PATCH] tty: Convert from tasklet to BH workqueue
Date: Thu, 4 Apr 2024 08:18:24 +0200 [thread overview]
Message-ID: <3358869b-db3a-40f3-b02b-4f1b46d5d724@kernel.org> (raw)
In-Reply-To: <20240403161559.19970-1-apais@linux.microsoft.com>
On 03. 04. 24, 18:15, Allen Pais wrote:
> The only generic interface to execute asynchronously in the BH context is
> tasklet; however, it's marked deprecated and has some design flaws. To
> replace tasklets, BH workqueue support was recently added. A BH workqueue
> behaves similarly to regular workqueues except that the queued work items
> are executed in the BH context.
>
> This patch converts drivers/tty/* from tasklet to BH workqueue.
Quickly looking into the changes, could you also elaborate why not to
convert most (all?) of them to (non-BH) wq? Or threaded IRQs. Much of
the code comes from the pre-WQ era.
thanks,
--
js
suse labs
next prev parent reply other threads:[~2024-04-04 6:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-03 16:15 [PATCH] tty: Convert from tasklet to BH workqueue Allen Pais
2024-04-04 6:13 ` Jiri Slaby
2024-04-04 6:18 ` Jiri Slaby [this message]
2024-04-09 15:48 ` Allen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3358869b-db3a-40f3-b02b-4f1b46d5d724@kernel.org \
--to=jirislaby@kernel.org \
--cc=apais@linux.microsoft.com \
--cc=gregkh@linuxfoundation.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=richard.genoud@gmail.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox