From: Jeff Johnson <jeff.johnson@oss.qualcomm.com>
To: Jakov Novak <jakovnovak30@gmail.com>, johannes@sipsolutions.net
Cc: dcbw@redhat.com, kees@kernel.org,
libertas-dev@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-wireless@vger.kernel.org, linville@tuxdriver.com,
mingo@kernel.org, skhan@linuxfoundation.org,
swilczek.lx@gmail.com,
syzbot+c99d17aa44dbdba16ad2@syzkaller.appspotmail.com,
tglx@kernel.org
Subject: Re: [resend PATCH v2 0/1] wifi: libertas: fix bug in Marvell Libertas driver
Date: Mon, 4 May 2026 08:59:58 -0700 [thread overview]
Message-ID: <3358cc85-4149-4136-9418-da400cc8be72@oss.qualcomm.com> (raw)
In-Reply-To: <20260504150416.4853-1-jakovnovak30@gmail.com>
On 5/4/2026 8:04 AM, Jakov Novak wrote:
> This is the same patch with the suggested tag and message fixes.
>
> Jakov Novak (1):
> wifi: libertas: add wake_up() call to properly notify
>
> drivers/net/wireless/marvell/libertas/if_usb.c | 1 +
> 1 file changed, 1 insertion(+)
>
1) A single patch doesn't need a cover letter
2) new versions of a patch should be a separate thread. Don't make new
versions "In-reply-to" the previous version.
3) Ingo Molnar once suggested a good template to follow for many
changes:https://lore.kernel.org/all/20131111113218.GF15810@gmail.com/
Over time I found this advice helpful, although not that exact template,
especially given that using "we" is now strongly discouraged.
I suggest something more like:
Currently, when <scenario>, <code reference> does <action>.
This has a <problem description>.
To address this issue, <imperative action to fix the code>.
<Any other comments which support this action such as describing how it fixes
the problem, how we know there are no side-effects (or known side-effects or
limitations)>
prev parent reply other threads:[~2026-05-04 16:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-10 21:32 [PATCH 0/1] usb: fix bug in marvell libertas driver Jakov Novak
2026-04-10 21:32 ` [PATCH 1/1] add wake_up call inside if_usb_disconnect Jakov Novak
2026-04-15 12:11 ` Johannes Berg
2026-04-15 13:31 ` [PATCH v2 0/1] wifi: libertas: fix bug in Marvell Libertas driver Jakov Novak
2026-04-15 13:31 ` [PATCH v2 1/1] wifi: libertas: add wake_up() call to properly notify fw_wq during disconnect Jakov Novak
2026-05-04 15:04 ` [resend PATCH v2 0/1] wifi: libertas: fix bug in Marvell Libertas driver Jakov Novak
2026-05-04 15:04 ` [resend PATCH v2 1/1] wifi: libertas: add wake_up() call to properly notify Jakov Novak
2026-05-04 15:11 ` [resend PATCH v2 0/1] wifi: libertas: fix bug in Marvell Libertas driver Johannes Berg
2026-05-04 15:59 ` Jeff Johnson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3358cc85-4149-4136-9418-da400cc8be72@oss.qualcomm.com \
--to=jeff.johnson@oss.qualcomm.com \
--cc=dcbw@redhat.com \
--cc=jakovnovak30@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=kees@kernel.org \
--cc=libertas-dev@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mingo@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=swilczek.lx@gmail.com \
--cc=syzbot+c99d17aa44dbdba16ad2@syzkaller.appspotmail.com \
--cc=tglx@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox